New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683083 link

Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Cursor is missing in Search box of History page on clicking 'More from this site'

Project Member Reported by ratnavar...@techmahindra.com, Jan 20 2017

Issue description

Chrome Version:57.0.2987.0 dev
OS:Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://history page.
(2)Click on 'Action' icon and select 'More from this site' option and observe(Refer video)

Actual Result: Cursor is not seen in search field.

Expected Result: Cursor should be seen in search field.

This is a regression issue broken in M-57.

Manual Bisect info:
Good Build:57.0.2959.0
Bad Build: 57.0.2960.0

 
Actualfocus.ogv
508 KB View Download
Expected focus.ogv
560 KB View Download

Comment 1 by ajha@chromium.org, Jan 20 2017

Components: -UI
Labels: Proj-MaterialDesign-WebUI OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest available canary(57.0.2986.0) on Mac OS 10.12.2.

Comment 2 by hdodda@chromium.org, Jan 20 2017

Cc: hdodda@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good Build:57.0.2958.0 (revision : 439976)
Bad Build: 57.0.2960.0 (revision : 440547)
You are probably looking for a change made after 440307 (known good), but no later than 440308 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/d4fc1786d2efd995867dfa22f058211de979c884..8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407

From the CL above, assigning the issue to the concern owner 

@dpapad - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2583353003

Thanks!

Comment 3 by dpa...@chromium.org, Jan 20 2017

Cc: tsergeant@chromium.org
Cc: msrchandra@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 685031  has been merged into this issue.

Comment 5 by dpa...@chromium.org, Jan 25 2017

@tsergeant: Do you have any suggestion on how to fix this?

By default a cr-action-menu focuses the anchor element (the dots icon) when closed. There is a 'change-query' event firing when the user clicks on "More from this site" button. Perhaps we could hook up to that event and focus the search input?
Sorry for the delay to reply.

Focusing search on `change-query` seems reasonable. I guess it comes down to the timing between that event firing and the menu refocusing the anchor element.

Ultimately, I don't think this is a high priority regression -- I don't think it would be common to click the 'More from this site' button and then immediately want to edit the search further.
Labels: -Pri-1 Pri-2
I agree with tsergeant's assessment of the priority of this issue.

Comment 8 by dpa...@chromium.org, Feb 16 2017

Cc: dpa...@chromium.org
 Issue 692904  has been merged into this issue.
 Issue 628081  has been merged into this issue.
Owner: ----
Status: Available (was: Assigned)
Marking bugs (mostly lower priority ones) that I am unlikely to get to soon as Available.
Components: UI>Browser>History

Sign in to add a comment