New issue
Advanced search Search tips

Issue 683066 link

Starred by 2 users

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

Improve w3c Web Platform Tests Selection tests pass score

Project Member Reported by yoichio@chromium.org, Jan 20 2017

Issue description

http://w3c-test.org/tools/runner/index.html
Run tests under path: /selection

Chrome 57.0.2985.0:
Passed Failed Timeouts Errors Not Run
14237  40093  2        0      0

FireFox 50.1.0:
Passed Failed Timeouts Errors Not Run
45522  11592  1        0      0

Edge 25.10586.672.0:
Passed Failed Timeouts Errors Not Run
13858  40472  2        0      0 



 

Comment 1 by tkent@chromium.org, Jan 23 2017

Blockedon: 681764
Components: -Blink>Editing Blink>Editing>Selection

Comment 2 by yosin@chromium.org, Jan 23 2017

Blockedon: 683795

Comment 3 by tkent@chromium.org, Feb 9 2017

Blockedon: 690240

Comment 4 by tkent@chromium.org, Feb 9 2017

Blockedon: 490206

Comment 5 by tkent@chromium.org, Feb 9 2017

Blockedon: 391673

Comment 7 by tkent@chromium.org, Feb 9 2017

58.0.3006.0
Passed Failed Timeouts Errors Not Run
15162  41952  0        0      0

ToT including r449213 and r449258
Passed Failed Timeouts Errors Not Run
22969  34145  0        0      0

Comment 8 by tkent@chromium.org, Feb 10 2017

Blockedon: 353069

Comment 9 by tkent@chromium.org, Feb 13 2017

Blockedon: 691422

Comment 10 by tkent@chromium.org, Feb 14 2017

Blockedon: 691887

Comment 11 by tkent@chromium.org, Feb 15 2017

Blockedon: 692400
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c15aa049a9c754139c3320bae7ab69c93919e68

commit 7c15aa049a9c754139c3320bae7ab69c93919e68
Author: yoichio <yoichio@chromium.org>
Date: Thu Feb 16 10:10:15 2017

Report w3c test result count for WPT

Some expected.txt have over 1000 tests mixing PASS/FAIL.
This CL changes testharnssreport to output counter for ease to recognize how
each WPT case gets better/worse for cases over 50 tests.

BUG=683066

Review-Url: https://codereview.chromium.org/2658793002
Cr-Commit-Position: refs/heads/master@{#450922}

[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-constructor-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-slice-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interfaces-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/custom-elements/adopted-callback-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/historical-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/lists/DOMTokenList-coverage-for-attributes-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElement-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElement-namespace-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElementNS-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-classlist-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-matches-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-cloneNode-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-lookupNamespaceURI-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-properties-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/ParentNode-querySelector-All-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/ParentNode-querySelector-All-xht-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/attributes-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/case-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-insertNode-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-mutations-splitText-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-surroundContents-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/traversal/NodeIterator-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/dom/traversal/TreeWalker-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/historical-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/browsers/the-window-object/window-properties-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/image-maps/image-map-processing-model/hash-name-reference-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-form-element/form-autocomplete-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-input-element/type-change-state-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interfaces-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_innerHTML_foreign-fragment-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/syntax/serializing-html-fragments/serializing-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/body-exposed-window-event-handlers-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/innerText/getter-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/innerText/setter-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/navigation-timing/idlharness-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/pointerevents/idlharness-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_attributes_nohover_pointers-manual-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-08-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-40-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-44-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-48-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-52-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-56-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/deleteFromDocument-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/selection/removeAllRanges-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/streams/readable-byte-streams/general-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/streams/readable-byte-streams/general.dedicatedworker-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/streams/readable-byte-streams/general.sharedworker-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/svg/interfaces-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/external/wpt/webvr/idlharness-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/platform/linux/external/wpt/FileAPI/blob/Blob-constructor-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/platform/win/external/wpt/FileAPI/blob/Blob-constructor-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-00-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-20-expected.txt
[modify] https://crrev.com/7c15aa049a9c754139c3320bae7ab69c93919e68/third_party/WebKit/LayoutTests/resources/testharnessreport.js

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6fe6ded242480abd3a1783311ecd810d2724db8

commit c6fe6ded242480abd3a1783311ecd810d2724db8
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Feb 17 14:14:48 2017

selection: Align collapse-NN.html and extend-NN.html to the latest draft.

https://www.w3.org/TR/selection-api/#dom-selection-collapse
> 3. If node's root is not the document associated with the context object,
> abort these steps.

https://www.w3.org/TR/selection-api/#dom-selection-extend
> 1. If node's root is not the document associated with the context object,
> abort these steps.

Also, this CL updates Blink's extend() implementation so that the root check is
done at the beginning of the function.
This CL fixes 4,259 tests in web-platform-tests/selection/.

BUG=683066
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2698413002 .
Cr-Commit-Position: refs/heads/master@{#451299}

[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/editing/selection/DOMSelection-crossing-document-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-crossing-document.js
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/collapse.js
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/common.js
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/extend.js
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/interfaces-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/LayoutTests/external/wpt/selection/removeAllRanges-expected.txt
[modify] https://crrev.com/c6fe6ded242480abd3a1783311ecd810d2724db8/third_party/WebKit/Source/core/editing/DOMSelection.cpp

Comment 15 by tkent@chromium.org, Feb 19 2017

58.0.3017.0 canary
Passed Failed Timeouts Errors Not Run
33441  23673  0        0      0
Pass rate: 58.6%

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329ba0e15e8853ef13e600776f1b3da4f30b0235

commit 329ba0e15e8853ef13e600776f1b3da4f30b0235
Author: tkent <tkent@chromium.org>
Date: Mon Feb 20 02:23:53 2017

selection: Do not run invalid sub-tests with unselectable endpoints.

* addRange.js:
It assumes any Range can be added to Selection. However the
latest draft defines that addRange() rejects Ranges in a root
different from Selection's document.
Some tests after addRange() with such Ranges were invalid.

https://w3c.github.io/selection-api/#dom-selection-addrange
> The method must set the context object's range to range by a
> strong reference (not by making a copy) if the root ([DOM4]) of
> the range's boundary points are the document associated with
> context object. Otherwise, this method must do nothing.

* exntend.js
extend() requires rangeCount>=1. setSelectionForwards() and
setSelectionBackwards() are assumed to ensure it. However, these
function can't set specified endpoints if they are in roots different
from Selection's document. We should skip such endpoints.

This CL removes 25,200 invalid tests.

BUG=683066

Review-Url: https://codereview.chromium.org/2700673005
Cr-Commit-Position: refs/heads/master@{#451545}

[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt
[delete] https://crrev.com/a8725caafe812944aa590f27e8711eab810bf1a1/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-08-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt
[delete] https://crrev.com/a8725caafe812944aa590f27e8711eab810bf1a1/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-40-expected.txt
[delete] https://crrev.com/a8725caafe812944aa590f27e8711eab810bf1a1/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-44-expected.txt
[delete] https://crrev.com/a8725caafe812944aa590f27e8711eab810bf1a1/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-48-expected.txt
[delete] https://crrev.com/a8725caafe812944aa590f27e8711eab810bf1a1/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-52-expected.txt
[delete] https://crrev.com/a8725caafe812944aa590f27e8711eab810bf1a1/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-56-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/addRange.js
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/common.js
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt
[modify] https://crrev.com/329ba0e15e8853ef13e600776f1b3da4f30b0235/third_party/WebKit/LayoutTests/external/wpt/selection/extend.js

Comment 17 by tkent@chromium.org, Feb 20 2017

Blockedon: -683795
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ace9e8b0287e6ab2b2beabf01e604fc327ad14b

commit 5ace9e8b0287e6ab2b2beabf01e604fc327ad14b
Author: tkent <tkent@chromium.org>
Date: Tue Feb 21 02:19:55 2017

selection: Do not run invalid sub-tests with unselectable endpoints.

collapseToStartEnd.html and isCollapsed.html assumed addRange() with nodes in
different roots succeeded. It's not consistent with the latest draft.

This CL removes 90 invalid tests, and removes 1 duplicated test for null endpoints.

BUG=683066

Review-Url: https://codereview.chromium.org/2709623002
Cr-Commit-Position: refs/heads/master@{#451686}

[delete] https://crrev.com/bdca41b6214271847f689ef3dedf4af1c5ec6d81/third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt
[modify] https://crrev.com/5ace9e8b0287e6ab2b2beabf01e604fc327ad14b/third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd.html
[delete] https://crrev.com/bdca41b6214271847f689ef3dedf4af1c5ec6d81/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed-expected.txt
[modify] https://crrev.com/5ace9e8b0287e6ab2b2beabf01e604fc327ad14b/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78f6af0ff4c8891082f4b6b366ec70d85d528cf8

commit 78f6af0ff4c8891082f4b6b366ec70d85d528cf8
Author: tkent <tkent@chromium.org>
Date: Tue Feb 21 04:36:13 2017

Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't throw.
The offset argument should be unsigned actually, and we can't check offset
validity for null node.

BUG=683066

Review-Url: https://codereview.chromium.org/2710593002
Cr-Commit-Position: refs/heads/master@{#451700}

[modify] https://crrev.com/78f6af0ff4c8891082f4b6b366ec70d85d528cf8/third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt
[delete] https://crrev.com/a6c107d90f66410de1d944109e2cce930142fdd7/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt
[delete] https://crrev.com/a6c107d90f66410de1d944109e2cce930142fdd7/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt
[delete] https://crrev.com/a6c107d90f66410de1d944109e2cce930142fdd7/third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt
[delete] https://crrev.com/a6c107d90f66410de1d944109e2cce930142fdd7/third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt
[delete] https://crrev.com/a6c107d90f66410de1d944109e2cce930142fdd7/third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt
[modify] https://crrev.com/78f6af0ff4c8891082f4b6b366ec70d85d528cf8/third_party/WebKit/LayoutTests/fast/dom/Selection/use-counters.html
[modify] https://crrev.com/78f6af0ff4c8891082f4b6b366ec70d85d528cf8/third_party/WebKit/LayoutTests/fast/text/selection-exceptions-expected.txt
[modify] https://crrev.com/78f6af0ff4c8891082f4b6b366ec70d85d528cf8/third_party/WebKit/LayoutTests/fast/text/selection-exceptions.html
[modify] https://crrev.com/78f6af0ff4c8891082f4b6b366ec70d85d528cf8/third_party/WebKit/Source/core/editing/DOMSelection.cpp

addRange spec was updated to ignore additional range:
http://w3c.github.io/selection-api/#dom-selection-addrange
https://github.com/w3c/selection-api/commit/042440b14ab558150e8d182873795dfdef0e2b0a

We can remove WPT tests about multiple range. yay.

Comment 21 by tkent@chromium.org, Feb 28 2017

Cc: yoichio@chromium.org
Owner: tkent@chromium.org
Status: Started (was: Available)
58.0.3025.3 canary
Passed Failed Timeouts Errors Not Run
26450  3139   0        0      0
Pass rate: 89.4%

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9a657134f60d44627d5f768e4db1035cfa0849

commit eb9a657134f60d44627d5f768e4db1035cfa0849
Author: tkent <tkent@chromium.org>
Date: Tue Feb 28 04:45:15 2017

selection: Update addRange-nn.html for 20170227 draft.

addRange() behavior was updated so that it does nothing if rangeCount > 0.
https://www.w3.org/TR/2017/WD-selection-api-20170227/#dom-selection-addrange

BUG=683066

Review-Url: https://codereview.chromium.org/2719813004
Cr-Commit-Position: refs/heads/master@{#453498}

[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt
[delete] https://crrev.com/53fad08c4b11481dd8f929d66ca8017fb9ff6d38/third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt
[modify] https://crrev.com/eb9a657134f60d44627d5f768e4db1035cfa0849/third_party/WebKit/LayoutTests/external/wpt/selection/addRange.js
[modify] https://crrev.com/eb9a657134f60d44627d5f768e4db1035cfa0849/third_party/WebKit/LayoutTests/external/wpt/selection/common.js

Owner: ----
Status: ExternalDependency (was: Started)
The remaining failures are just two.

- Binding: We don't agree with WebIDL spec; crbug.com/643712
- setBaseAndExtent(null); https://github.com/w3c/selection-api/issues/72

Labels: -Pri-1 Pri-3
Blockedon: 417124
59.0.3030.0 canary
Passed Failed Timeouts Errors Not Run
25667  2      0        0      0
Pass rate: 99.99%

Sign in to add a comment