New issue
Advanced search Search tips

Issue 683063 link

Starred by 1 user
Status: WontFix
Owner:
jdoerrie@chromium.org
Closed: Jan 2017
Cc:
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Fix bug when transitioning from an empty to a non-empty password list

Project Member Reported by kavvaru@chromium.org, Jan 20 2017 
jdoerrie@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit:  https://codereview.chromium.org/2571443002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=672869

Thanks,

Comment 1 by vabr@chromium.org, Jan 27 2017

Labels: -Pri-1 -M-56 Pri-3
Thanks for the bug report.
While I agree that tests are needed, I do not agree that the referenced bug was a high-priority regression. Also, the old settings WebUI apparently has no tests at all. Adding some will require a substantial effort, while the whole settings WebUI is actively being deprecated and replaced by an MD version right now. I suggest that jdoerrie@ checks that the MD version has proper testing and then closes this as WontFix.

Comment 2 by jdoerrie@chromium.org, Jan 30 2017

Status: WontFix (was: Assigned)
I can confirm what vabr@ said above. The MD version has proper tests, specifically here: https://codesearch.chromium.org/chromium/src/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Due to the reasons stated above I am marking this as WontFix.

Comment 3 by ranjitkan@chromium.org, Aug 8 2017

Components: -Test>Missing Tests>Missing
►

Sign in to add a comment