[Content suggestions] Fetch More does not add any new snippets |
|||||
Issue descriptionAfter the recent change of https://codereview.chromium.org/2639933003/, the following sequence of events happens after user presses "More" for articles: - another 10 suggestions are fetched and returned in the FetchMore callback - SuggestionsSection appends these 10 new suggestions to the existing 10 ones - Before the new suggestions are seen by the user, RemoteSuggestionsProvider notifies ContentSuggestionsService that it has a new set of 10 suggestions (just the new ones) - ContentSuggestionsService notifies the UI that there is a new set of 10 suggestions for ARTICLEs. - SuggestionsSection trims the new 10 suggestions from the current list of 20 suggestions (the first 10 are seen so they must stay, the new list has only 10 suggestions which is what we try to honour, thus we shorten the current list to only the 10 seen suggestions). This needs to get fixed and merged for M57. - One solution is to revert CLs 2639533003 and 2639933003. - Another solution is to merge a simple fix (ready).
,
Jan 20 2017
Issue 683018 has been merged into this issue.
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/389bba160bee7a83f0fd3b0227b6757dc8ae3e77 commit 389bba160bee7a83f0fd3b0227b6757dc8ae3e77 Author: jkrcal <jkrcal@chromium.org> Date: Wed Jan 25 12:55:46 2017 [Content suggestions] Never update snippets after FetchMore The new logic for replacing snippets does not work well for the case after more suggestions are fetched by the provider on demand and appended to the list. This CL switches off replacing the snippets after any snippets have been appended. BUG= 683050 Review-Url: https://codereview.chromium.org/2644143003 Cr-Commit-Position: refs/heads/master@{#446005} [modify] https://crrev.com/389bba160bee7a83f0fd3b0227b6757dc8ae3e77/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/389bba160bee7a83f0fd3b0227b6757dc8ae3e77/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
,
Jan 25 2017
Please verify on Canary and merge ASAP. Thx!
,
Jan 27 2017
Verified on 58.0.2993.0.
,
Jan 27 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/948a7f73e91c84ef7bf4f9921887a39a11fbb20f commit 948a7f73e91c84ef7bf4f9921887a39a11fbb20f Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Jan 27 09:48:10 2017 [Content suggestions] Never update snippets after FetchMore The new logic for replacing snippets does not work well for the case after more suggestions are fetched by the provider on demand and appended to the list. This CL switches off replacing the snippets after any snippets have been appended. BUG= 683050 Review-Url: https://codereview.chromium.org/2644143003 Cr-Commit-Position: refs/heads/master@{#446005} (cherry picked from commit 389bba160bee7a83f0fd3b0227b6757dc8ae3e77) Review-Url: https://codereview.chromium.org/2656323002 . Cr-Commit-Position: refs/branch-heads/2987@{#139} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/948a7f73e91c84ef7bf4f9921887a39a11fbb20f/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/948a7f73e91c84ef7bf4f9921887a39a11fbb20f/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jkrcal@chromium.org
, Jan 20 2017