New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683031 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3% regression in memory.top_10_mobile at 444626:444668

Project Member Reported by mlippautz@chromium.org, Jan 20 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=683031

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg4PuT4AsM


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 20 2017

Cc: amp@chromium.org
Owner: amp@chromium.org

=== Auto-CCing suspected CL author amp@chromium.org ===

Hi amp@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : amp
  Commit : ea73f799eb7fe7a9b5836f2c491bd99dbf933089
  Date   : Thu Jan 19 04:05:39 2017
  Subject: Skip video overlay surface management when in VR.

Bisect Details
  Configuration: android_nexus9_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg
  Change       : 0.90% | 5954110.4 -> 6007830.86667

Revision             Result                  N
chromium@444579      5954110 +- 17282.2      6      good
chromium@444608      5948392 +- 11775.7      6      good
chromium@444623      5959987 +- 23668.6      6      good
chromium@444630      5959519 +- 34960.0      6      good
chromium@444632      5958247 +- 33251.3      6      good
chromium@444633      5954547 +- 25956.4      6      good
chromium@444634      6000239 +- 10182.3      6      bad       <--
chromium@444637      6007831 +- 14950.9      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8989962420460096400

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5316563957186560


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jan 20 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : amp
  Commit : ea73f799eb7fe7a9b5836f2c491bd99dbf933089
  Date   : Thu Jan 19 04:05:39 2017
  Subject: Skip video overlay surface management when in VR.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg
  Change       : 0.75% | 5940748.62222 -> 5985130.26667

Revision             Result                  N
chromium@444625      5940749 +- 66643.8      9      good
chromium@444631      5930900 +- 50934.3      9      good
chromium@444633      5939278 +- 76188.3      9      good
chromium@444634      5984447 +- 52959.3      9      bad       <--
chromium@444636      5979597 +- 14095.8      6      bad
chromium@444647      5983203 +- 41994.1      9      bad
chromium@444668      5985130 +- 32908.8      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8989962672931792464

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5867486827773952


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 6 by amp@chromium.org, Jan 20 2017

I'm not familiar with how to handle perf bugs like this.

Do we roll back my change, or just try to diagnose what is causing the difference?

Comment 7 by amp@chromium.org, Jan 20 2017

I wonder if this is caused by the re-enabling of vr shell in testing config rather than any of the actual code changes.

How can I try things out to verify the impact?

Comment 8 by mustaq@chromium.org, Jan 20 2017

Seems the regression is too small, <1% for the two remaining perf plots. I will close the bug, fell free to reopen if you think it is important.

Comment 9 by amp@chromium.org, Feb 6 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment