Non-Regression : Unwanted Black space is seen in Camera App |
||
Issue descriptionChrome Version: 57.0.2984.0/9200.0.0 dev-channel Falco, Blaze and Glimmer OS: Chrome What steps will reproduce the problem? (1)Sign into User ->Launch Camera App -> Enable 'Toggle Mirroring','Toggle Timer','Toggle Multi-shot options and now click on 'Take a picture' (2)Use Right/left arrow buttons from keyboard to select Toggle filter options ->Now Click on 'Go to Gallery' -> Now select a picture (3)Press 'Tab' button until focus reaches to 'Delete' option -> Click on 'Delete' -> Click on 'Enter' so that picture is deleted (4)Now again press 'Tab' until focus reaches to 'Go Back' option and hit 'Enter' button ->In Camera Gallery Again press 'Tab' until focus reaches to 'Go Back' option and hit 'Enter' button (5)Now Focus is seen on 'Take a picture' option -> Press 'Tab' button until focus is seen on 'Go to gallery' option->Now again press 'Tab' button and observe Unwanted Black space at Toggle filter options (Please refer video) Expected: No Space should be seen Actual: Instead Unwanted Black space is seen This is Non-Regression Issue seen from M-55 @yuli :Please confirm the Issue
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/a7287310078077369669beee66eba6c3c18a80d2 commit a7287310078077369669beee66eba6c3c18a80d2 Author: Yuli Huang <yuli@chromium.org> Date: Wed Mar 07 05:16:25 2018 Fix toolbar expanded incorrectly. 1. Avoid toolbar expanded when camera-view isn't active. 2. Fix remembering elements' tab-index before a view goes inactive. 3. Adjust calling orders in view.js for code consistency. BUG= chromium:683007 TEST=Tested manually on elm. Change-Id: I80425e3d3534b23b8d32907ebdff220e82dc07f6 Reviewed-on: https://chromium-review.googlesource.com/945037 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/a7287310078077369669beee66eba6c3c18a80d2/src/js/views/camera.js [modify] https://crrev.com/a7287310078077369669beee66eba6c3c18a80d2/src/js/view.js
,
Mar 7 2018
Please verify it on the upcoming camera app canary.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7287310078077369669beee66eba6c3c18a80d2 commit a7287310078077369669beee66eba6c3c18a80d2 Author: Yuli Huang <yuli@chromium.org> Date: Wed Mar 07 05:16:25 2018 Fix toolbar expanded incorrectly. 1. Avoid toolbar expanded when camera-view isn't active. 2. Fix remembering elements' tab-index before a view goes inactive. 3. Adjust calling orders in view.js for code consistency. BUG= chromium:683007 TEST=Tested manually on elm. Change-Id: I80425e3d3534b23b8d32907ebdff220e82dc07f6 Reviewed-on: https://chromium-review.googlesource.com/945037 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/a7287310078077369669beee66eba6c3c18a80d2/src/js/view.js [modify] https://crrev.com/a7287310078077369669beee66eba6c3c18a80d2/src/js/views/camera.js
,
Today
(6 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad9d6a734e8195e73ff6361d7135e30c7875054d commit ad9d6a734e8195e73ff6361d7135e30c7875054d Author: Yuli Huang <yuli@chromium.org> Date: Wed Mar 07 05:16:25 2018 Fix toolbar expanded incorrectly. 1. Avoid toolbar expanded when camera-view isn't active. 2. Fix remembering elements' tab-index before a view goes inactive. 3. Adjust calling orders in view.js for code consistency. BUG= chromium:683007 TEST=Tested manually on elm. Change-Id: I80425e3d3534b23b8d32907ebdff220e82dc07f6 Reviewed-on: https://chromium-review.googlesource.com/945037 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> |
||
►
Sign in to add a comment |
||
Comment 1 by y...@chromium.org
, Jan 16 2018