New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682998 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Mac
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Regression : Chrome crashes on sign in.

Reported by yfulgaon...@etouch.net, Jan 20 2017

Issue description

Chrome Version : 57.0.2987.0 (Official Build) ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} 32/64 bit
OS : Windows(7,8,10)

What steps will reproduce the problem?
1. Launch Chrome, go to chrome://settings and click on ‘Sign in to chrome’.
2. Sign in using valid credential and observe.

Actual : Chrome crashes on sign in.
Expected : Chrome should not crash.

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2986.0
Bad build : 57.0.2987.0
 
Update : 

Precondition : Freshly install chrome.

Crash ID a50dd616-d0f7-4c7c-8713-e8be1d38c9d5 (Server ID: 087f240880000000)


Actual_video.mp4
1.1 MB View Download
Cc: rbasuvula@chromium.org
Labels: ReleaseBlock-Dev
Owner: pav...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue in fresh install due to that unable to run the per revision bisect.So providing the manual bisect using below revisions.

Good build: 57.0.2986.0 (Revision: 444600)
Bad build: 57.0.2987.0 (Revision: 444943)


Stack Trace:
============
Thread 55 CRASHED [EXCEPTION_ACCESS_VIOLATION_EXEC @ 0x00007fff99c14e50 ] MAGIC SIGNATURE THREAD
Stack Quality89%Show frame trust levels
0x00007fff99c14e50	(chrome.dll + 0x02bc4e50 )	
0x00007fff99431157	(chrome.dll -get_updates_processor.cc:194 )	syncer::GetUpdatesProcessor::PrepareGetUpdates(syncer::EnumSet<syncer::ModelType,2,38>,sync_pb::ClientToServerMessage *)
0x00007fff9943080f	(chrome.dll -get_updates_processor.cc:176 )	syncer::GetUpdatesProcessor::DownloadUpdates(syncer::EnumSet<syncer::ModelType,2,38> *,syncer::SyncCycle *,bool)
0x00007fff99417398	(chrome.dll -syncer.cc:112 )	syncer::Syncer::DownloadAndApplyUpdates(syncer::EnumSet<syncer::ModelType,2,38> *,syncer::SyncCycle *,syncer::GetUpdatesProcessor *,bool)
0x00007fff99417309	(chrome.dll -syncer.cc:88 )	syncer::Syncer::ConfigureSyncShare(syncer::EnumSet<syncer::ModelType,2,38>,sync_pb::GetUpdatesCallerInfo_GetUpdatesSource,syncer::SyncCycle *)
0x00007fff994183c2	(chrome.dll -sync_scheduler_impl.cc:490 )	syncer::SyncSchedulerImpl::DoConfigurationSyncCycleJob(syncer::SyncSchedulerImpl::JobPriority)
0x00007fff99419f06	(chrome.dll -sync_scheduler_impl.cc:711 )	syncer::SyncSchedulerImpl::TrySyncCycleJobImpl()
0x00007fff97a5e091	(chrome.dll -bind_internal.h:305 )	base::internal::InvokeHelper<1,void>::MakeItSo<void ( content::RenderWidgetHostImpl::*const &)(void),base::WeakPtr<content::RenderWidgetHostImpl> const &>(void ( content::RenderWidgetHostImpl::*const &)(void),base::WeakPtr<content::RenderWidgetHostImpl> const &)
0x00007fff9713ee02	(chrome.dll -callback.h:68 )	base::internal::RunMixin<base::Callback<void ,0,0> >::Run( ?? )
0x00007fff971530c4	(chrome.dll -task_annotator.cc:52 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x00007fff970faec3	(chrome.dll -message_loop.cc:421 )	base::MessageLoop::RunTask(base::PendingTask *)
0x00007fff970fbb04	(chrome.dll -message_loop.cc:523 )	base::MessageLoop::DoWork()
0x00007fff97154418	(chrome.dll -message_pump_default.cc:33 )	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x00007fff9711f8d3	(chrome.dll -run_loop.cc:37 )	base::RunLoop::Run()
0x00007fff970f971d	(chrome.dll -thread.cc:328 )	base::Thread::ThreadMain()
0x00007fff970c4f3f	(chrome.dll -platform_thread_win.cc:84 )	base::`anonymous namespace'::ThreadFunc
0x00007fffc6038101	(KERNEL32.DLL + 0x00018101 )	BaseThreadInitThunk
0x00007fffc706c5b3	(ntdll.dll + 0x0005c5b3 )	RtlUserThreadStart


CHANGE-LOG URL:
----------------
https://chromium.googlesource.com/chromium/src/+log/57.0.2986.0..57.0.2987.0?pretty=fuller&n=10000


From the CL above, assigning the issue to the concern owner

@pavely: 
------------------
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2641523004

Adding RB-Dev to this issue if not required please feel free to remove.

Thank you!
Labels: OS-Linux
Update: 

Able to reproduce the issue in Ubuntu 14.04 and unable to test the issue in MAC OS as build version #57.0.2987.0 for mac was failed.

Thank You!
Labels: OS-Mac
Update :
Issue is also reproducible in Mac(10.12.1, 10.11.6, 10.12) on build #57.0.2987.0

Thank You!
Issue 683102 has been merged into this issue.

Comment 6 by nick@chromium.org, Jan 20 2017

Components: Services>Sync
Labels: OS-Android
Crash showing up in Android too.

Comment 7 by pav...@chromium.org, Jan 20 2017

Status: Started (was: Assigned)

Comment 8 by zea@chromium.org, Jan 20 2017

Labels: -Pri-1 Pri-0
Bumping priority as this completely breaks signin.

Comment 9 by cma...@chromium.org, Jan 20 2017

Labels: OS-iOS
Cc: anan...@chromium.org
pavely@, Can you please revert the change ASAP?

PS: This is a branching (2987) build and we are waiting for rest of the M57 branching tasks.

Thank you!

Comment 11 by s...@chromium.org, Jan 20 2017

The change has been reverted, see https://codereview.chromium.org/2644373003/
I've reverted my change: http://crrev.com/2644373003
Sorry for the inconvenience.
I am seeing it as already reverted (https://codereview.chromium.org/2644373003/). Could you please merge it to 2987 branch?

Comment 14 by dimu@google.com, Jan 20 2017

I'm triggering a new 2987 build now.
I've merged revert to 2987: http://crrev.com/2641253004
Thank you Pavel for all the help.
Project Member

Comment 17 by sheriffbot@chromium.org, Jan 20 2017

Labels: FoundIn-M-57 Fracas
Users experienced this crash on the following builds:

Win Canary 57.0.2987.0 -  10.42 CPM, 57 reports, 56 clients (signature syncer::GetUpdatesProcessor::PrepareGetUpdates)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 18 by sheriffbot@chromium.org, Jan 20 2017

Labels: FoundIn-M-57 Fracas
Users experienced this crash on the following builds:

Win Canary 57.0.2987.0 -  11.52 CPM, 63 reports, 61 clients (signature syncer::`anonymous namespace'::ShouldRequestEncryptionKey)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 19 by ajha@chromium.org, Jan 23 2017

Labels: TE-Verified-57.0.2987.6 TE-Verified-M57
Verified the revert in the latest M-57 branched build(57.0.2987.6) on Windows-10, Mac OS 10.12.2 and Linux Ubuntu 14.04. Browser doesn't crash on signing into chrome. Adding the verified label therefore.

Comment 20 by zea@chromium.org, Jan 23 2017

Can we close this out/downgrade priority?
Yes, downgrading to P2.
Why downgrade instead of close out the issue?  Since the crash is fixed, this bug is fixed, right?  Reference the original bug tracking the first landing when re-landing.
Status: Fixed (was: Started)

Sign in to add a comment