New issue
Advanced search Search tips

Issue 682990 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove AshTestHelper::SupportsMultipleDisplays and AshTestBase::SupportsMultipleDisplays

Project Member Reported by jamescook@chromium.org, Jan 20 2017

Issue description

These were added to support Windows. They always return true on Chrome OS, so we could remove them. 

However, we might want to keep these a little longer for running unit tests mustash (which doesn't yet support multiple displays).

Do we ever want to run tests based on AshTestBase under a version of mustash that doesn't support multiple displays?  If not I can remove them (and their dozens of callers).

sky / kylechar - thoughts?

 

Comment 1 by sky@chromium.org, Jan 20 2017

Actually, the mash tests do support multiple displays:

bool WmTestBase::SupportsMultipleDisplays() const {
  return true;
}

That said, the mash code doesn't support the full set of configuration options as cash, but it will have to at some point. I suspect you can remove these functions entirely.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2ecd79007349fb621cff07448816a5c09bfd3d2

commit f2ecd79007349fb621cff07448816a5c09bfd3d2
Author: jamescook <jamescook@chromium.org>
Date: Tue Jan 24 21:16:59 2017

chromeos: Remove AshTestBase::SupportsMultipleDisplays

This function existed to support Ash on Windows. Since we dropped Windows
last year it always returns true. Eliminate it and all callers.

Clean up a few unnecessary OS_CHROMEOS checks along the way.

BUG= 682990 
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2653593004
Cr-Commit-Position: refs/heads/master@{#445812}

[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/common/devtools/ash_devtools_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/common/test/ash_test.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/common/test/ash_test.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/common/test/ash_test_impl.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/common/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/cursor_window_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/display_error_observer_chromeos_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/display_util_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/extended_mouse_warp_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/mouse_cursor_event_filter_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/resolution_notification_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/screen_ash_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/unified_mouse_warp_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/drag_drop/drag_drop_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/drag_drop/drag_drop_interactive_uitest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/drag_drop/drag_drop_tracker_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/magnifier/partial_magnification_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/mus/test/ash_test_impl_mus.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/mus/test/ash_test_impl_mus.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/mus/test/wm_test_base.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/mus/top_level_window_factory_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/screen_util_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/test/ash_test_base.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/test/ash_test_base.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/test/ash_test_helper.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/test/ash_test_helper.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/test/ash_test_impl_aura.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/test/ash_test_impl_aura.h
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/touch/touch_observer_hud_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/utility/screenshot_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/video_detector_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/f2ecd79007349fb621cff07448816a5c09bfd3d2/ui/display/manager/display_manager.cc

Status: Fixed (was: Assigned)

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment