New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682983 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Traveling - Back 2/6
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Delete unused Apache Java http libraries

Project Member Reported by aelias@chromium.org, Jan 20 2017

Issue description

https://codereview.chromium.org/11421224 introduced some third-party libraries like apache-mime4j and apache-httpcomponents for Chrome sync.  Grepping doesn't turn up any usage of these, are these safe to delete nowadays?
 
Yeah, they were used for our Google Cloud Print integration and Chrome to Mobile.
It seems like I added the following third_party directories:
apache-mime4j
guava
httpcomponents-client
httpcomponents-core
jarjar

I'll put up a patch to delete them.
I have this CL out for review: https://codereview.chromium.org/2642403002/
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b85b9eb8d1d91ccc172f53eec3e277eab60c47ce

commit b85b9eb8d1d91ccc172f53eec3e277eab60c47ce
Author: nyquist <nyquist@chromium.org>
Date: Fri Jan 20 19:20:19 2017

Remove unnecessary third party dependencies

The CL https://codereview.chromium.org/11421224 added several
third party dependencies required for the feature Chrome to Mobile.

As the feature has been removed, this CL deals with removing
the dependencies that the CL added. The action taken for each new
dependency is listed below:

- apache-mime4j: Removed from .gitignore and DEPS.
- guava: Was deleted in https://codereview.chromium.org/602203003,
         but was later added back in
         https://codereview.chromium.org/2041583002. However, as its
         uses are now only related to tests, the 'testonly = true' flag
         has been added to its BUILD.gn file.
- httpcomponents-client: Removed from .gitignore and DEPS.
- httpcomponents-core: Removed from .gitignore and DEPS.
- jarjar: Removed from .gitignore as
          https://codereview.chromium.org/2072873003 only deleted the
          DEPS entry.

BUG= 682983 

Review-Url: https://codereview.chromium.org/2642403002
Cr-Commit-Position: refs/heads/master@{#445123}

[modify] https://crrev.com/b85b9eb8d1d91ccc172f53eec3e277eab60c47ce/.gitignore
[modify] https://crrev.com/b85b9eb8d1d91ccc172f53eec3e277eab60c47ce/DEPS
[modify] https://crrev.com/b85b9eb8d1d91ccc172f53eec3e277eab60c47ce/third_party/guava/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment