Most LayoutTests which use internals or testRunner methods (besides the test system ones like dumpAsText()) should be rewritten as unit tests using SimTests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b34b8896fe3b95563ea13eab767b102a120d464e commit b34b8896fe3b95563ea13eab767b102a120d464e Author: esprehn <esprehn@chromium.org> Date: Sat Jan 28 02:05:47 2017 Remove internals.address(node) BUG= 682982 Review-Url: https://codereview.chromium.org/2643773007 Cr-Commit-Position: refs/heads/master@{#446881} [modify] https://crrev.com/b34b8896fe3b95563ea13eab767b102a120d464e/third_party/WebKit/LayoutTests/resources/dump-as-markup.js [modify] https://crrev.com/b34b8896fe3b95563ea13eab767b102a120d464e/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/b34b8896fe3b95563ea13eab767b102a120d464e/third_party/WebKit/Source/core/testing/Internals.h [modify] https://crrev.com/b34b8896fe3b95563ea13eab767b102a120d464e/third_party/WebKit/Source/core/testing/Internals.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/415f9bab260d050f3471daae4282a267aa954094 commit 415f9bab260d050f3471daae4282a267aa954094 Author: esprehn <esprehn@chromium.org> Date: Thu Mar 23 07:53:03 2017 Switch Shadow DOM V0 <content> FeatureSet tests to SimTest. This lets us remove three methods from internals. Once we have this new SimTest we can also port lots of other tests and remove more internals methods specific to testing shadow dom. BUG= 682982 Review-Url: https://codereview.chromium.org/2647843002 Cr-Commit-Position: refs/heads/master@{#459018} [delete] https://crrev.com/dee8e0a41990efbaec2435faff764baee5b894d9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-select-attribute-featureset-expected.txt [delete] https://crrev.com/dee8e0a41990efbaec2435faff764baee5b894d9/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-select-attribute-featureset.html [modify] https://crrev.com/415f9bab260d050f3471daae4282a267aa954094/third_party/WebKit/Source/core/dom/Element.h [modify] https://crrev.com/415f9bab260d050f3471daae4282a267aa954094/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/415f9bab260d050f3471daae4282a267aa954094/third_party/WebKit/Source/core/testing/Internals.h [modify] https://crrev.com/415f9bab260d050f3471daae4282a267aa954094/third_party/WebKit/Source/core/testing/Internals.idl [modify] https://crrev.com/415f9bab260d050f3471daae4282a267aa954094/third_party/WebKit/Source/web/BUILD.gn [add] https://crrev.com/415f9bab260d050f3471daae4282a267aa954094/third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp
Archiving P3s older than 1 year with no owner or component.
Comment 1 by bugdroid1@chromium.org
, Jan 28 2017