New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682964 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html failing on chromium.webkit/WebKit Linux Trusty

Project Member Reported by alancutter@chromium.org, Jan 20 2017

Issue description

virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html failing on chromium.webkit/WebKit Linux Trusty

Type: build-failure

Builders failed on: 
- WebKit Linux Trusty: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-lose-restore-max-int-size.html&testType=webkit_tests



Looks like it flakily has an extra newline.

Diff:
--- /b/rr/tmpV_NDsj/w/layout-test-results/virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size-expected.txt
+++ /b/rr/tmpV_NDsj/w/layout-test-results/virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size-actual.txt
@@ -11,13 +11,13 @@
 PASS ctx.isContextLost() is true
 PASS contextLostTest is true
 PASS ctx.isContextLost() is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
 PASS Graphics context lost event dispatched.
 PASS contextLostTest is true
 PASS ctx.isContextLost() is true
 PASS Context restored event dispatched after context lost.
 PASS contextLostTest is false
 PASS ctx.isContextLost() is false
+PASS successfullyParsed is true
 
+TEST COMPLETE
+
 
Cc: junov@chromium.org
Another failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/619

22:38:10.786 28814 worker/3 virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html output stderr lines:
22:38:10.786 28814   Xlib:  extension "RANDR" missing on display ":9".
22:38:10.789 2228 [7/59] virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html failed unexpectedly (text diff)
22:38:10.789 28814 worker/3 virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html failed:
22:38:10.789 28814 worker/3  text diff

I'm updating the expectations with Failure in https://codereview.chromium.org/2655053003/
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc5bb40aed5443930544af6292de928234edb6b2

commit cc5bb40aed5443930544af6292de928234edb6b2
Author: kjellander <kjellander@chromium.org>
Date: Thu Jan 26 13:30:11 2017

Update expectation for virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html

The test is failing flakily. Example:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/619

BUG= 682964 
TBR=junov@chromium.org

Review-Url: https://codereview.chromium.org/2655053003
Cr-Commit-Position: refs/heads/master@{#446315}

[modify] https://crrev.com/cc5bb40aed5443930544af6292de928234edb6b2/third_party/WebKit/LayoutTests/TestExpectations

Cc: -junov@chromium.org
Labels: -Sheriff-Chromium
Owner: junov@chromium.org
Status: Assigned (was: Available)
junov@chromium.org can you have a look? Removing from sheriff queue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67e9c930f58bb30971795c3da424dfe3bf00906

commit a67e9c930f58bb30971795c3da424dfe3bf00906
Author: alancutter <alancutter@chromium.org>
Date: Sat Feb 04 00:47:43 2017

Deflake virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html

This patch rewrites fast/canvas/canvas-lose-restore-max-int-size.html
to use testharness.js and avoid random deviations in the test output
from causing the test to fail flakily.

New test output:
This is a testharness.js-based test.
PASS Context should initially not be lost
PASS Context should be lost when size is set to an extremely large number and then restored when set to a reasonable number
PASS contextlost event should fire after size is set to extremely large number
PASS contextrestored event should fire after size is restored to a reasonable number
Harness: the test ran to completion.

BUG= 682964 

Review-Url: https://codereview.chromium.org/2643193002
Cr-Commit-Position: refs/heads/master@{#448127}

[modify] https://crrev.com/a67e9c930f58bb30971795c3da424dfe3bf00906/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/d8bc9322a6dfa8e8aa12f5d5feb28cca53399202/third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-max-int-size-expected.txt
[modify] https://crrev.com/a67e9c930f58bb30971795c3da424dfe3bf00906/third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-max-int-size.html

Status: Fixed (was: Assigned)

Sign in to add a comment