New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682951 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Sign in to add a comment

Detect existing autotests which get broken with ext4 crypto (if any)

Project Member Reported by hashimoto@chromium.org, Jan 20 2017

Issue description

With ext4 crypto, existing autotests around Cryptohome and ARC can get broken.
To enable ext4 crypto by default, we should detect them to fix (if any).

Possibly related issues (see also other blocker issues of  issue 347322 ):
- Issue 613577 ARC: ext4 crypto test: xfstest: Need to adapat SELinux rules to allow mounting /dev/loopN
-  Issue 646626  test: multiple tests of platform_Cryptohome* broken
- Issue 682419 minijail: clear use keyring when access to user directory is not needed by service
 

Comment 1 by kinaba@chromium.org, Jan 25 2017

Blockedon: 684914

Comment 2 by kinaba@chromium.org, Jan 25 2017

Status: Started (was: Assigned)

Comment 3 by kinaba@chromium.org, Jan 25 2017

Issues  684914 : ARC container does not start under ext4crypto + the fake login of autotest.

Comment 4 by kinaba@chromium.org, Jan 30 2017

Blockedon: 686611

Comment 5 by kinaba@chromium.org, Jan 30 2017

 Issue 686611 : With ext4crypt autotest cannot exit from the previous login in the test setup.
FWIW: with 684914 and 686611 fixed, `test_that suite:bvt-cq` had only 5 failures.

I'm fairly confident cheets_* failures are not ext4crypto specific--it's ARC++-N matter in general.
Not fully sure about video. I'll check just in case.

* cheets_SELinuxTest
FAIL: Unexpected context for Android /sys/kernel/debug: Expected: u:object_r:debugfs:s0, Actual: u:object_r:debugfs_tracing:s0

* video_ChromeRTCHWEncodeUsed
ERROR: Cannot find Media.RTCVideoEncoderInitEncodeSuccess histogram.

* cheets_SettingsBridge
ERROR: Timed out waiting for condition: org.chromium.arc.intent_helper is running

* cheets_Notification
FAIL: Unhandled unicode: Unhandled JsonRPCError: JsonRPC Error code: -32002, 
Message: android.support.test.uiautomator.UiObjectNotFoundException: UiSelector[TEXT=Send notification]

* video_ChromeRTCHWEncodeUsed.arc
ERROR: Cannot find Media.RTCVideoEncoderInitEncodeSuccess histogram.
I found nya@ had filed cheets_* failure bugs on N b/34864566, b/34864508, and b/34863940.

I suspected  crbug.com/602295  for histogram thing, but even with the latest Chrome I couldn't pass the tests.
And our dashboard says 
https://wmatrix.googleplex.com/platform/bvt?platforms=sentry&suites=bvt-cq
it can pass on N.

I'll retry with ToT Samus-cheets again tomorrow.
Video tests failed even with ext4crypt disabled samus. I stopped worrying about that in this context.
$ test_that suite:bvt-inline

/tmp/test_that_results_zIEpSw/results-09-security_StatefulPermissions/security_StatefulPermissions            [  FAILED  ]
/tmp/test_that_results_zIEpSw/results-09-security_StatefulPermissions/security_StatefulPermissions              FAIL: Unexpected files/perms in stateful
....(long list of unexpected files under /home/.shadow/jash/mount/)....

/tmp/test_that_results_zIEpSw/results-31-login_Cryptohome/login_Cryptohome                                    [  FAILED  ]
/tmp/test_that_results_zIEpSw/results-31-login_Cryptohome/login_Cryptohome                                      ERROR: Cryptohome created a vault but did not mount.

/tmp/test_that_results_zIEpSw/results-47-security_SandboxedServices/security_SandboxedServices                [  FAILED  ]
/tmp/test_that_results_zIEpSw/results-47-security_SandboxedServices/security_SandboxedServices                  FAIL: One or more processes failed sandboxing
/tmp/test_that_results_zIEpSw/results-47-security_SandboxedServices/security_SandboxedServices                  02/03 13:49:20.126 ERROR|security_Sandboxed:0322| New services are not allowed to run as root, but these are: ['adb']
/tmp/test_that_results_zIEpSw/results-47-security_SandboxedServices/security_SandboxedServices                  02/03 13:49:20.129 ERROR|security_Sandboxed:0326| Failed sandboxing: ['adb']

The last one is probably unrelated, but the first two will be related. I'll take a look and file separate bugs.
Blockedon: 688256
Blockedon: 688258
Filed

 Issue 688258 : login_Cryptohome
 Issue 688256 : security_StatefulPermissions
Blockedon: 689340
 Issue 689340 : security_ProfilePermissions
Blockedon: 689381
Now the only remaining issue for bvt-cq and bvt-inline to pass should be  Bug 688258 .
fyi: On ToT Samus I re-run the tests and saw several more failures saying "Failure while starting browser backend.",
but looking at the stacktrace this looks to be the same as b/35306355 (i.e., not ext4crypto specific).

Status: Fixed (was: Started)
The last CL is still in the CQ, but I believe we can declare "detect" phase as titled in this issue is resolved.
Status: Verified (was: Fixed)
Great. Thanks for creating this meta bug. I feel a lot better about the ext4 testing now! 

Sign in to add a comment