New issue
Advanced search Search tips

Issue 682940 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

linux - toolbar buttons have extra borders

Project Member Reported by est...@chromium.org, Jan 20 2017

Issue description

filing this in case the fix needs to be merged to m57.


 
gacefpgenmpfhjnb.png
8.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2b5c14fa70447b692fab4f7a9660729cf55b38

commit 7e2b5c14fa70447b692fab4f7a9660729cf55b38
Author: estade <estade@chromium.org>
Date: Fri Jan 20 19:33:48 2017

Fix gtk theme regression introduced in 477aca494328f

Turns out we do need to explicitly clear the border images. This bug is
visible when you hover a toolbar button.

BUG= 682940 

Review-Url: https://codereview.chromium.org/2639423005
Cr-Commit-Position: refs/heads/master@{#445130}

[modify] https://crrev.com/7e2b5c14fa70447b692fab4f7a9660729cf55b38/chrome/browser/ui/libgtkui/gtk_ui.cc

Comment 2 by gov...@chromium.org, Jan 23 2017


A friendly reminder that M57 Beta launch is coming soon on February 2nd! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Dev (before Beta promotion). Thank you!

Comment 3 by est...@chromium.org, Jan 23 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Jan 23 2017

Please merge your change to M57 branch 2987 ASAP (if possible before 5:00 PM PT today).So we can pick it for Dev release tomorrow (02/24).

Comment 6 by est...@chromium.org, Jan 23 2017

Status: Fixed (was: Started)
https://codereview.chromium.org/2645423002

bugdroid is slacking off

Comment 7 by gov...@chromium.org, Jan 24 2017

Labels: -Merge-Approved-57 merge-merged-2987
Per comment #6, this is already merged to M57.
Components: UI>Browser>TabStrip

Sign in to add a comment