New issue
Advanced search Search tips

Issue 682927 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 353069



Sign in to add a comment

Count selection intersection in Selection.addRange()

Project Member Reported by tkent@chromium.org, Jan 20 2017

Issue description

Count Blink-specific behavior of Selection.addRange().

 

Comment 2 by tkent@chromium.org, Jan 20 2017

Labels: -M-56 Merge-Request-56 Merge-Request-57
Status: Fixed (was: Started)
Want to merge the change to branches if possible.

Project Member

Comment 3 by sheriffbot@chromium.org, Jan 20 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 21 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 23 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aaf339f87746f0088dbc156e604e828fcfb21f0

commit 6aaf339f87746f0088dbc156e604e828fcfb21f0
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jan 23 04:47:15 2017

Merge "Add a UseCounter for selection intersection in Selection.addRange()." to M57 branch.

This CL has no user-visible behavior changes.

BUG= 682927 

Review-Url: https://codereview.chromium.org/2646903002
Cr-Commit-Position: refs/heads/master@{#444980}
(cherry picked from commit bc3500b781a02784c3624110e9ea70e022f2cd64)

Review-Url: https://codereview.chromium.org/2648183002 .
Cr-Commit-Position: refs/branch-heads/2987@{#16}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/6aaf339f87746f0088dbc156e604e828fcfb21f0/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/6aaf339f87746f0088dbc156e604e828fcfb21f0/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/6aaf339f87746f0088dbc156e604e828fcfb21f0/tools/metrics/histograms/histograms.xml

Labels: -Merge-Review-56 Merge-Rejected-56
Our next desktop release goes directly to stable, and this is a Pri-3 metrics bug - sorry, you missed the boat for M56.  Rejecting merge.

Sign in to add a comment