https://codereview.chromium.org/2644733005/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b684241f1f14948c108d715ebe7c5a9427a9fcd0

commit b684241f1f14948c108d715ebe7c5a9427a9fcd0
Author: cwallez <cwallez@chromium.org>
Date: Wed Feb 01 16:02:09 2017

Revert of Copy GPU workaround flags from browser to GPU process (patchset #4 id:20002 of https://codereview.chromium.org/2644733005/ )

Reason for revert:
There is a gpu_unittests failure on OSX:
AssertionError: Browser and GPU process list of driver bugworkarounds are not equal

Starting from https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/10498

This CL seems like the culprit, reverting.

Original issue's description:
> Copy GPU workaround flags from browser to GPU process
>
> BUG= 682912 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2644733005
> Cr-Commit-Position: refs/heads/master@{#447356}
> Committed: https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364c48f9118a328

TBR=kbr@chromium.org,zmo@chromium.org,kainino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 682912 

Review-Url: https://codereview.chromium.org/2666353002
Cr-Commit-Position: refs/heads/master@{#447523}

[modify] https://crrev.com/b684241f1f14948c108d715ebe7c5a9427a9fcd0/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/b684241f1f14948c108d715ebe7c5a9427a9fcd0/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/b684241f1f14948c108d715ebe7c5a9427a9fcd0/gpu/config/gpu_driver_bug_list.cc
[modify] https://crrev.com/b684241f1f14948c108d715ebe7c5a9427a9fcd0/gpu/config/gpu_driver_bug_list.h
[modify] https://crrev.com/b684241f1f14948c108d715ebe7c5a9427a9fcd0/gpu/config/gpu_driver_bug_list_json.cc

Above failure seems to be specific to Mac Nvidia. The flag below is seen in the browser process but not the GPU process. This workaround is triggered on all Nvidia.

> unpack_overlapping_rows_separately_unpack_buffer

https://cs.chromium.org/chromium/src/gpu/config/gpu_driver_bug_list_json.cc?l=1709&rcl=06f6cd0653d33dc0e087cf3aede5df399ffc9db0

The failure is specific to dual-gpu systems (and happens to be triggered by an Nvidia-only workaround).

The failure wasn't seen in the CQ because gpu_process_launch_tests wasn't run on a dual-gpu system.

The test needs some reworking to handle this case. Trying to figure out why _GpuProcess_only_one_workaround is okay, as it hits the same logic.

Comment 1 looks similar as one of the first problem that I have been working on in this area: https://codereview.chromium.org/1415603009/

Are you sure it was not run on a dual gpu system ? I am almost sure that at some point  this test was running on a mac that had 2 gpu (I remember a timing issue on it), but maybe this machine went out at some point or I can be wrong.

I do not have any proper time to work on that at the moment but I am at least available to discuss if you have any questions on some of these tests.

In any case it is good that you are working on this. Thx!

gpu_process_launch_tests wasn't run on a dual-gpu system in the CQ, but it was on the FYI waterfall. So I was able to commit the change without it failing tests, only to create a failure on the FYI waterfall, so it was reverted.

I think I've solved this, but I'm still working on verifying it locally before I commit it again.

https://codereview.chromium.org/2671773003

kbr: assigning to you while you verify the fix on your dual-gpu system.

To verify, just run gpu_process_launch_tests with my patch.

Please assign back to me (or just click commit) when verified.

Confirmed on https://codereview.chromium.org/2644733005 that the latest patch set works correctly on a dual-GPU MacBook Pro.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48d029d278e71c7837e118a4d6f72951dd2dd05

commit c48d029d278e71c7837e118a4d6f72951dd2dd05
Author: kainino <kainino@chromium.org>
Date: Mon Feb 27 08:11:49 2017

Copy GPU workaround flags from browser to GPU process

BUG= 682912 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Original-Commit-Position: refs/heads/master@{#447356}
Committed: https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364c48f9118a328
Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#453170}

[modify] https://crrev.com/c48d029d278e71c7837e118a4d6f72951dd2dd05/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/c48d029d278e71c7837e118a4d6f72951dd2dd05/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/c48d029d278e71c7837e118a4d6f72951dd2dd05/gpu/config/gpu_driver_bug_list.cc
[modify] https://crrev.com/c48d029d278e71c7837e118a4d6f72951dd2dd05/gpu/config/gpu_driver_bug_list.h
[modify] https://crrev.com/c48d029d278e71c7837e118a4d6f72951dd2dd05/gpu/config/gpu_driver_bug_list_json.cc