New issue
Advanced search Search tips

Issue 682892 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

UI glitches on Performance and Memory panels

Project Member Reported by alph@chromium.org, Jan 20 2017

Issue description

Network pane font is inconsistent
Target select combobox on Memory panel.
Default tree view height is too small.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ffeda5222ba52d797c90dd247be0113c0ced577

commit 5ffeda5222ba52d797c90dd247be0113c0ced577
Author: alph <alph@chromium.org>
Date: Fri Jan 20 02:43:13 2017

Fix UI glitches on Performance and Memory panels

Network pane font was inconsistent.
Target select combobox on Memory panel had no padding.
Default tree view height was too small.

BUG= 682892 

Review-Url: https://codereview.chromium.org/2640403003
Cr-Commit-Position: refs/heads/master@{#444959}

[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js
[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/5ffeda5222ba52d797c90dd247be0113c0ced577/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Comment 2 by alph@chromium.org, Jan 20 2017

Labels: -Pri-3 Merge-Request-57 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0c54c01686c19ed8c9d4dee664aa6312951cb0

commit 5b0c54c01686c19ed8c9d4dee664aa6312951cb0
Author: alph <alph@chromium.org>
Date: Fri Jan 20 22:24:35 2017

Revert of Fix UI glitches on Performance and Memory panels (patchset #2 id:20001 of https://codereview.chromium.org/2640403003/ )

Reason for revert:
Broke timeline flamechart vertical scroll

Original issue's description:
> Fix UI glitches on Performance and Memory panels
>
> Network pane font was inconsistent.
> Target select combobox on Memory panel had no padding.
> Default tree view height was too small.
>
> BUG= 682892 
>
> Review-Url: https://codereview.chromium.org/2640403003
> Cr-Commit-Position: refs/heads/master@{#444959}
> Committed: https://chromium.googlesource.com/chromium/src/+/5ffeda5222ba52d797c90dd247be0113c0ced577

TBR=pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 682892 

Review-Url: https://codereview.chromium.org/2646193003
Cr-Commit-Position: refs/heads/master@{#445184}

[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js
[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/5b0c54c01686c19ed8c9d4dee664aa6312951cb0/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d74d5b6592b0cef8b085bfa07711473dfae707f

commit 2d74d5b6592b0cef8b085bfa07711473dfae707f
Author: alph <alph@chromium.org>
Date: Sat Jan 21 02:04:47 2017

Fix UI glitches on Performance and Memory panels

Network pane font was inconsistent.
Target select combobox on Memory panel had no padding.
Default tree view height was too small.

BUG= 682892 

Review-Url: https://codereview.chromium.org/2640403003
Cr-Original-Commit-Position: refs/heads/master@{#444959}
Committed: https://chromium.googlesource.com/chromium/src/+/5ffeda5222ba52d797c90dd247be0113c0ced577
Review-Url: https://codereview.chromium.org/2640403003
Cr-Commit-Position: refs/heads/master@{#445249}

[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js
[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/2d74d5b6592b0cef8b085bfa07711473dfae707f/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Project Member

Comment 5 by sheriffbot@chromium.org, Jan 22 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Jan 23 2017

Is this change applicable to any specific OS or All OSs?

Comment 7 by alph@chromium.org, Jan 24 2017

Labels: OS-All
All OSes

Comment 8 by gov...@chromium.org, Jan 24 2017

Thank you.
Is this M57 merge request for CL listed at #4? If yes, is this change well baked/verified in Canary and safe to merge?

Comment 9 by alph@chromium.org, Jan 24 2017

Yes, it's #4 for M57. The change is in Canary for couple days already. It works.
Labels: -Merge-Review-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on comment #9. Please merge ASAP. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a8c564ad4579613a1f02dd7148625ff17b8526

commit 24a8c564ad4579613a1f02dd7148625ff17b8526
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Jan 24 22:54:17 2017

Fix UI glitches on Performance and Memory panels

Network pane font was inconsistent.
Target select combobox on Memory panel had no padding.
Default tree view height was too small.

BUG= 682892 

Review-Url: https://codereview.chromium.org/2640403003
Cr-Original-Commit-Position: refs/heads/master@{#444959}
Committed: https://chromium.googlesource.com/chromium/src/+/5ffeda5222ba52d797c90dd247be0113c0ced577
Review-Url: https://codereview.chromium.org/2640403003
Cr-Commit-Position: refs/heads/master@{#445249}
(cherry picked from commit 2d74d5b6592b0cef8b085bfa07711473dfae707f)

Review-Url: https://codereview.chromium.org/2655793002 .
Cr-Commit-Position: refs/branch-heads/2987@{#76}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js
[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/24a8c564ad4579613a1f02dd7148625ff17b8526/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Comment 12 by alph@chromium.org, Jan 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment