[WPT Export] When merging PRs, rebase and FF instead of merging |
||||||||
Issue descriptionWe shouldn't be creating merge commits.
,
Jan 25 2017
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0a2ec09d1087b572e70002fce286231c0fef823 commit e0a2ec09d1087b572e70002fce286231c0fef823 Author: jeffcarp <jeffcarp@chromium.org> Date: Thu Jan 26 05:51:36 2017 [WPT Export] Add merge_method: rebase to WPTGitHub.merge_pull_request BUG= 682883 Review-Url: https://codereview.chromium.org/2658713002 Cr-Commit-Position: refs/heads/master@{#446244} [modify] https://crrev.com/e0a2ec09d1087b572e70002fce286231c0fef823/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
,
Jan 26 2017
,
Feb 1 2017
It looks like the script is still creating merge commits: https://github.com/w3c/web-platform-tests/commits/master
,
Feb 19 2017
,
Mar 7 2017
Turns out this isn't working because the rebase merge method for PRs is still in preview mode. https://developer.github.com/v3/pulls/#input-2 So we can either: - Opt into the preview API now using the media Accept header - Wait until it becomes stable
,
Mar 7 2017
How about we just wait then, and letting it be consistent across the quarter should make it easier to track the "time to export" metrics.
,
Mar 9 2017
,
Apr 13 2017
This was enabled by GitHub recently and commits are now being rebased and fast forwarded onto master: https://github.com/w3c/web-platform-tests/commits/master?after=690108a07534ca09de27af8509a6bcc07ac0969e+5
,
Jul 3 2017
,
Jul 3 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jeffcarp@chromium.org
, Jan 25 2017