New issue
Advanced search Search tips

Issue 682881 link

Starred by 1 user
Status: Fixed
Owner:
gangwu@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Do not use base::RandBytesAsString for random string in commit.cc

Project Member Reported by gangwu@chromium.org, Jan 19 2017 
should not use base::RandBytesAsString since it won't generate ASCII/UTF-8 string.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20cbb6147f3978751c6cc69a9773dd3e93b2df56

commit 20cbb6147f3978751c6cc69a9773dd3e93b2df56
Author: gangwu <gangwu@chromium.org>
Date: Fri Jan 20 15:51:06 2017

[Sync] Do not use base::RandBytesAsString to generate random string

Protobuf should use UTF-8 string, and base::RandBytesAsString won't generate ASCII/UTF-8 string.

BUG= 682881 

Review-Url: https://codereview.chromium.org/2637173004
Cr-Commit-Position: refs/heads/master@{#445065}

[modify] https://crrev.com/20cbb6147f3978751c6cc69a9773dd3e93b2df56/components/sync/engine_impl/commit.cc

Comment 2 by gangwu@chromium.org, Jan 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment