ToolsMenu will be refactored and a new VC implementation will be done in ios/clean. This bug is intended to track these changes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f539fb3b13ffc0e25538dbe9e6886c314a7f541 commit 1f539fb3b13ffc0e25538dbe9e6886c314a7f541 Author: sczs <sczs@chromium.org> Date: Sat Jan 21 00:06:46 2017 [ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC Creates .h and .mm files for ToolsMenuViewToolsCell, and deletes ToolsMenuButton entirely since it had no implementation. BUG=682880 Review-Url: https://codereview.chromium.org/2640423003 Cr-Commit-Position: refs/heads/master@{#445218} [modify] https://crrev.com/1f539fb3b13ffc0e25538dbe9e6886c314a7f541/ios/chrome/browser/ui/tools_menu/BUILD.gn [modify] https://crrev.com/1f539fb3b13ffc0e25538dbe9e6886c314a7f541/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm [add] https://crrev.com/1f539fb3b13ffc0e25538dbe9e6886c314a7f541/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h [add] https://crrev.com/1f539fb3b13ffc0e25538dbe9e6886c314a7f541/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8733b51b07e8bd99fb80058e3bffc0c39ece1f1d commit 8733b51b07e8bd99fb80058e3bffc0c39ece1f1d Author: sczs <sczs@chromium.org> Date: Mon Feb 13 17:49:43 2017 [ios clean] ToolsMenu UI changes Changes the Menu UI to look approximately like the current iOS version. Screenshots: iOS Clean: https://drive.google.com/open?id=0Byo6-Nuda2jgcUsxU09OQnRWNTQ Current App: https://drive.google.com/open?id=0Byo6-Nuda2jgQ3JOazRNaEh1Qms BUG=682880 Review-Url: https://codereview.chromium.org/2685823002 Cr-Commit-Position: refs/heads/master@{#449997} [modify] https://crrev.com/8733b51b07e8bd99fb80058e3bffc0c39ece1f1d/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm [modify] https://crrev.com/8733b51b07e8bd99fb80058e3bffc0c39ece1f1d/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/8733b51b07e8bd99fb80058e3bffc0c39ece1f1d/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f21fa5131ea7281d0b990b461eb244574c3c9d4 commit 7f21fa5131ea7281d0b990b461eb244574c3c9d4 Author: sczs <sczs@chromium.org> Date: Thu Feb 16 19:53:14 2017 [ios clean] Add overflow buttons for ToolsMenu. -ToolsMenu adds a StackView subclass (MenuOverflowControlsStack) as a first element when in compact widths. -ToolsMenu is dismissed everytime the ToolbarLayout changes (Rotation, iPad multitasking,etc.) this mimics current behavior. -MenuOverflowControlsStack currently uses ToolbarButtons as a placeholder, but this is not necessarily how it needs to be. -MenuOverflowControlsStack UI is not yet ready, this CL is more about the logic of adding/removing the Stack, and not the contents. Screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgQmFzYXZsNkd2ZlU BUG=682880 Review-Url: https://codereview.chromium.org/2693043002 Cr-Commit-Position: refs/heads/master@{#451065} [modify] https://crrev.com/7f21fa5131ea7281d0b990b461eb244574c3c9d4/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/7f21fa5131ea7281d0b990b461eb244574c3c9d4/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm [modify] https://crrev.com/7f21fa5131ea7281d0b990b461eb244574c3c9d4/ios/clean/chrome/browser/ui/tools/BUILD.gn [add] https://crrev.com/7f21fa5131ea7281d0b990b461eb244574c3c9d4/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h [add] https://crrev.com/7f21fa5131ea7281d0b990b461eb244574c3c9d4/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm [modify] https://crrev.com/7f21fa5131ea7281d0b990b461eb244574c3c9d4/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db commit 8a9ed5b3b71d3915fb734b99a5e6e0db550d79db Author: sczs <sczs@chromium.org> Date: Thu Feb 23 19:29:54 2017 [ios] Creates ToolsMenuModel Class Extracts the Model related code from ToolsMenuViewController to a new class named ToolsMenuModel. This CL is just the first step on refactoring and decoupling the Model logic, so it can be used by the new ToolsMenuVC and the old one. BUG=682880 Review-Url: https://codereview.chromium.org/2706293008 Cr-Commit-Position: refs/heads/master@{#452585} [modify] https://crrev.com/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db/ios/chrome/browser/ui/tools_menu/BUILD.gn [add] https://crrev.com/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [add] https://crrev.com/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm [modify] https://crrev.com/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ef4aa62f40aa8ef1ab4d6841102f8bf1d931bf2 commit 8ef4aa62f40aa8ef1ab4d6841102f8bf1d931bf2 Author: sczs <sczs@chromium.org> Date: Thu Feb 23 23:21:13 2017 Revert of [ios] Creates ToolsMenuModel Class (patchset #4 id:60001 of https://codereview.chromium.org/2706293008/ ) Reason for revert: Broke EG test Original issue's description: > [ios] Creates ToolsMenuModel Class > Extracts the Model related code from ToolsMenuViewController to a new > class named ToolsMenuModel. > > This CL is just the first step on refactoring and decoupling the Model > logic, so it can be used by the new ToolsMenuVC and the old one. > > BUG=682880 > > Review-Url: https://codereview.chromium.org/2706293008 > Cr-Commit-Position: refs/heads/master@{#452585} > Committed: https://chromium.googlesource.com/chromium/src/+/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db TBR=marq@chromium.org,edchin@chromium.org,lpromero@chromium.org,rohitrao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682880 Review-Url: https://codereview.chromium.org/2711263002 Cr-Commit-Position: refs/heads/master@{#452670} [modify] https://crrev.com/8ef4aa62f40aa8ef1ab4d6841102f8bf1d931bf2/ios/chrome/browser/ui/tools_menu/BUILD.gn [delete] https://crrev.com/c32079e66898f3d463f9ac8d83e16a119382a84b/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [delete] https://crrev.com/c32079e66898f3d463f9ac8d83e16a119382a84b/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm [modify] https://crrev.com/8ef4aa62f40aa8ef1ab4d6841102f8bf1d931bf2/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4523043de7614ef55438aaa42fadafb905a0e56 commit d4523043de7614ef55438aaa42fadafb905a0e56 Author: sczs <sczs@chromium.org> Date: Fri Mar 10 01:29:40 2017 [ios] Creates ToolsMenuConstants file Since many tests depend on just these constants, I think is better to create a separate file for these since the Model classes might change again and we don't wan't to keep updating these tests. This CL removes the model code from ToolsMenuVC and fixes a bug in ToolsMenuModel Downstream tests compile and run successfully against these changes. BUG=682880 Review-Url: https://codereview.chromium.org/2722693002 Cr-Commit-Position: refs/heads/master@{#455949} [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/keyboard_commands_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/settings/block_popups_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/settings/translate_ui_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/BUILD.gn [add] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_menu_constants.h [add] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_menu_constants.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm [modify] https://crrev.com/d4523043de7614ef55438aaa42fadafb905a0e56/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8072f5360ed41e1e41265a1d528047aa4dcd3a0 commit f8072f5360ed41e1e41265a1d528047aa4dcd3a0 Author: sczs <sczs@chromium.org> Date: Wed Mar 29 01:24:22 2017 [ios clean] Creates ToolsMenu Mediator and Consumer The CL primary purpose is to create the necessary Consumer, Mediator and ToolsMenuItem files, and hook them together. The consumer protocol method is not intended to be final and will remain as a placeholder for now. The model is also hardcoded and will be replaced in a future CL. BUG=682880 Review-Url: https://codereview.chromium.org/2769963007 Cr-Commit-Position: refs/heads/master@{#460258} [modify] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/menu_view_controller.h [modify] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [add] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/tools_consumer.h [modify] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm [add] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/tools_mediator.h [add] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/tools_mediator.mm [add] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/tools_menu_item.h [add] https://crrev.com/f8072f5360ed41e1e41265a1d528047aa4dcd3a0/ios/clean/chrome/browser/ui/tools/tools_menu_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3edea41ec63503945b1135b34ccf1122098512d commit b3edea41ec63503945b1135b34ccf1122098512d Author: sczs <sczs@chromium.org> Date: Tue Apr 04 21:10:45 2017 [ios] Use dispatcher for ToolsMenu commands. CL is pretty straightforward, but I want to note that I removed toolbar actions since I don't think they will be needed in this case anymore. BUG= 682880 Review-Url: https://codereview.chromium.org/2785213003 Cr-Commit-Position: refs/heads/master@{#461838} [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/actions/BUILD.gn [delete] https://crrev.com/2c0a8f906209efba7539baf7fe1b270b950082c4/ios/clean/chrome/browser/ui/actions/tools_menu_actions.h [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/commands/navigation_commands.h [delete] https://crrev.com/2c0a8f906209efba7539baf7fe1b270b950082c4/ios/clean/chrome/browser/ui/commands/toolbar_commands.h [add] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/commands/tools_menu_commands.h [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.h [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/tools/menu_view_controller.h [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/tools/tools_coordinator.h [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm [modify] https://crrev.com/b3edea41ec63503945b1135b34ccf1122098512d/ios/showcase/toolbar/sc_toolbar_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a103411c274920f778226cd05370003edf85047 commit 1a103411c274920f778226cd05370003edf85047 Author: sczs <sczs@chromium.org> Date: Thu Apr 13 02:13:53 2017 [ios clean] ToolsMenu UnitTests Adds a simple test for the mediator and creates a placeholder test file for the coordinator. BUG=682880 Review-Url: https://codereview.chromium.org/2812463002 Cr-Commit-Position: refs/heads/master@{#464247} [modify] https://crrev.com/1a103411c274920f778226cd05370003edf85047/ios/clean/chrome/browser/ui/tools/BUILD.gn [add] https://crrev.com/1a103411c274920f778226cd05370003edf85047/ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm [add] https://crrev.com/1a103411c274920f778226cd05370003edf85047/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm [modify] https://crrev.com/1a103411c274920f778226cd05370003edf85047/ios/clean/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c commit 206ca2c9b0ec44066b9275badb2ae2f9bb748b4c Author: sczs <sczs@chromium.org> Date: Thu Apr 13 16:37:28 2017 [ios] Move ToolsMenuConfiguration to shared. BUG=682880 Review-Url: https://codereview.chromium.org/2815233002 Cr-Commit-Position: refs/heads/master@{#464438} [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/stack_view/BUILD.gn [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/stack_view/stack_view_controller.mm [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/toolbar/toolbar_controller.mm [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/tools_menu/BUILD.gn [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm [modify] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm [add] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/shared/chrome/browser/ui/tools_menu/BUILD.gn [rename] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.h [rename] https://crrev.com/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c/ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1348142cf8663a4e48249e9c0497c14ed91aa0b5 commit 1348142cf8663a4e48249e9c0497c14ed91aa0b5 Author: sczs <sczs@chromium.org> Date: Thu Apr 13 20:45:21 2017 [ios clean] Adds ToolsMenu to TabGrid The button with the three dots will now show the ToolsMenu instead of Settings. This is the first step in order to change the content depending on the context. For that reason we can see the navigation buttons in the screenshot, but didn't make those changes in this CL. FYI: The settings window will work from the "TabGrid" ToolsMenu, but not the "Toolbar" ToolsMenu. This is currently happening and is not being caused by this CL, not sure yet what broke it but I will fix it and create a test for that. Screenshot: https://drive.google.com/file/d/0Byo6-Nuda2jgTURCSDFoUUNJVEU/view?usp=sharing BUG=682880 Review-Url: https://codereview.chromium.org/2810603002 Cr-Commit-Position: refs/heads/master@{#464535} [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/actions/settings_actions.h [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/clean/chrome/browser/ui/tab_grid/ui_button+cr_tab_grid.mm [modify] https://crrev.com/1348142cf8663a4e48249e9c0497c14ed91aa0b5/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31019d751c35578034f6bf1f37467c8aa9ffff70 commit 31019d751c35578034f6bf1f37467c8aa9ffff70 Author: sczs <sczs@chromium.org> Date: Wed Apr 19 17:40:22 2017 [ios clean] Use ToolsMenuConfiguration for Menu context. Screenshots: https://drive.google.com/file/d/0Byo6-Nuda2jgaDNxMVYtWmEtUXc/view?usp=sharing https://drive.google.com/file/d/0Byo6-Nuda2jgaXJEYmZ3RzdVUlU/view?usp=sharing BUG=682880 Review-Url: https://codereview.chromium.org/2814963002 Cr-Commit-Position: refs/heads/master@{#465659} [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/tools_consumer.h [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/tools_coordinator.h [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/tools_mediator.h [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/tools_mediator.mm [modify] https://crrev.com/31019d751c35578034f6bf1f37467c8aa9ffff70/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc73346d1a81f7c76c4fbb567439082f6e00e8c3 commit fc73346d1a81f7c76c4fbb567439082f6e00e8c3 Author: sczs <sczs@chromium.org> Date: Fri Apr 21 17:48:12 2017 [ios clean] Functionality for menu overflow navigation buttons Adds functionality to stop and reload buttons in the ToolsMenu overflow stack. Some refactoring. BUG=682880 Review-Url: https://codereview.chromium.org/2817203003 Cr-Commit-Position: refs/heads/master@{#466384} [modify] https://crrev.com/fc73346d1a81f7c76c4fbb567439082f6e00e8c3/ios/clean/chrome/browser/ui/tools/menu_view_controller.h [modify] https://crrev.com/fc73346d1a81f7c76c4fbb567439082f6e00e8c3/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59e55ca446fab6e48a6da7687044b3998e319052 commit 59e55ca446fab6e48a6da7687044b3998e319052 Author: sczs <sczs@chromium.org> Date: Thu May 11 15:22:51 2017 [ios] Dismisses ToolsMenu on Layout changes. Re-adding this now that we don't depend on the UI responderChain for dismissing the ToolsMenu. BUG= 682880 Review-Url: https://codereview.chromium.org/2869903002 Cr-Commit-Position: refs/heads/master@{#470961} [modify] https://crrev.com/59e55ca446fab6e48a6da7687044b3998e319052/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/59e55ca446fab6e48a6da7687044b3998e319052/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9105e9bb16be5b830a0d6eae1fec84fedd49f24 commit e9105e9bb16be5b830a0d6eae1fec84fedd49f24 Author: sczs <sczs@chromium.org> Date: Fri May 19 22:25:40 2017 [ios clean] ToolsMenu ScrollView and Close Button ToolsMenu now scrolls and the close button is always floating in the corner. SS: https://drive.google.com/open?id=0Byo6-Nuda2jgemxMaUlxcUh0TDA BUG=682880 Review-Url: https://codereview.chromium.org/2887263003 Cr-Commit-Position: refs/heads/master@{#473365} [modify] https://crrev.com/e9105e9bb16be5b830a0d6eae1fec84fedd49f24/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h [modify] https://crrev.com/e9105e9bb16be5b830a0d6eae1fec84fedd49f24/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm [modify] https://crrev.com/e9105e9bb16be5b830a0d6eae1fec84fedd49f24/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e commit bd95b4b8ee9e4cf14ed3021a194d6265db10d33e Author: sczs <sczs@chromium.org> Date: Tue May 23 16:56:05 2017 [ios clean] Fixes Menu Overflow Controls UI UI screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgSUJKeTBQMndhbnc Constraints screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgYnZ3SnRPdERxQzA BUG=682880 Review-Url: https://codereview.chromium.org/2901663002 Cr-Commit-Position: refs/heads/master@{#473943} [modify] https://crrev.com/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e/ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h [modify] https://crrev.com/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h [modify] https://crrev.com/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm [modify] https://crrev.com/bd95b4b8ee9e4cf14ed3021a194d6265db10d33e/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a692a678babe78f8b2ddde3cf6bcc276aea8d4 commit 87a692a678babe78f8b2ddde3cf6bcc276aea8d4 Author: sczs <sczs@chromium.org> Date: Wed May 24 02:35:13 2017 [ios clean] Creates ToolsMenu model. Creates a new Model since re-using the old one would require too much work and not a lot of gain. (Will expand this in the Design Doc, but Marq agreed with me that it wasn't worth it). This follows the pattern of the old Model but simplifies it since we won't have as many different cases as before. Most items are hidden, and some have been left visible just to show how it works. TabSwitcher Menu Screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgRjJvNnJJYkhKN1U Web Menu Screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgSENLR1J2T3RxRlk BUG=682880 Review-Url: https://codereview.chromium.org/2889483002 Cr-Commit-Position: refs/heads/master@{#474131} [modify] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [modify] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/tools_mediator.mm [add] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/tools_mediator_private.h [modify] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm [add] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/tools_menu_model.h [add] https://crrev.com/87a692a678babe78f8b2ddde3cf6bcc276aea8d4/ios/clean/chrome/browser/ui/tools/tools_menu_model.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b7f68fcf6b065e000dcb23e2a54ad7869c7c9f9 commit 9b7f68fcf6b065e000dcb23e2a54ad7869c7c9f9 Author: sczs <sczs@chromium.org> Date: Fri May 26 18:29:50 2017 [ios clean] Fixes ToolsMediator unit test Changes EXPECT_EQ to EXPECT_NSEQ for NSString comparisons. BUG=682880 Review-Url: https://codereview.chromium.org/2906133002 Cr-Commit-Position: refs/heads/master@{#475067} [modify] https://crrev.com/9b7f68fcf6b065e000dcb23e2a54ad7869c7c9f9/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f58f1c268f7ec4a304a87e23d117b563188de22d commit f58f1c268f7ec4a304a87e23d117b563188de22d Author: sczs <sczs@chromium.org> Date: Thu Jun 01 00:08:00 2017 [ios clean] ToolsMenu Mediator observes Webstate. -ToolsMenu observes Webstate so it can correctly update the Overflow controls stop/reload buttons. -Some unittest refactoring. Display stop while loading screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgcFppc1hyU1VaSHM Display reload after it has loaded screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgTWx4UzhJVUZlclU BUG=682880 Review-Url: https://codereview.chromium.org/2906313003 Cr-Commit-Position: refs/heads/master@{#476103} [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/tools_consumer.h [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/tools_coordinator.h [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/tools_mediator.h [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/tools_mediator.mm [modify] https://crrev.com/f58f1c268f7ec4a304a87e23d117b563188de22d/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16cafbab6bef1dce2175df58a54028effdacd074 commit 16cafbab6bef1dce2175df58a54028effdacd074 Author: sczs <sczs@chromium.org> Date: Wed Jun 21 10:03:23 2017 [ios clean] Adds ToolsMenu to Showcase. ToolsMenu wasn't working in showcase since it now depends on a model. This CL fixes that issue. It also removes the tools_actions file since it was not needed anymore. Screenshot CompactWidth: https://drive.google.com/open?id=0Byo6-Nuda2jgTVB1VUVsUUJNeFE Screenshot RegularWidth: https://drive.google.com/open?id=0Byo6-Nuda2jgOUhXYU0ycTRFdTA BUG=682880 Review-Url: https://codereview.chromium.org/2944703002 Cr-Commit-Position: refs/heads/master@{#481162} [modify] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [delete] https://crrev.com/64e2012a9e0278ff735674d16db1c44caefc91ae/ios/clean/chrome/browser/ui/tools/tools_actions.h [modify] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/clean/chrome/browser/ui/tools/tools_menu_model.mm [modify] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/showcase/BUILD.gn [modify] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/showcase/core/showcase_model.mm [add] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/showcase/tools_menu/BUILD.gn [add] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/showcase/tools_menu/sc_tools_coordinator.h [add] https://crrev.com/16cafbab6bef1dce2175df58a54028effdacd074/ios/showcase/tools_menu/sc_tools_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f commit 2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f Author: sczs <sczs@chromium.org> Date: Fri Jun 23 16:08:58 2017 [ios clean] Refactors ToolsMenu presentation - Creates TransitionController objects so Coordinators don't have to conform to the UIViewControllerTransitioningDelegate protocol. This will make it easy to switch out to different transitions or make AB experiments. - Moves the presentationFrame calculation into the MenuPresentationController, which also reduces code duplication. In order to make this possible the MenuPresentationDelegate has changed. BUG=682880 Review-Url: https://codereview.chromium.org/2952213003 Cr-Commit-Position: refs/heads/master@{#481912} [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/animators/BUILD.gn [add] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.h [add] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/animators/zoom_transition_controller.mm [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.mm [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/presenters/menu_presentation_delegate.h [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/root/root_container_view_controller.mm [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm [add] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/tools/tools_menu_transition_controller.h [add] https://crrev.com/2141c4d83c85a4ebc5f2cf5d365dd51ff0822d6f/ios/clean/chrome/browser/ui/tools/tools_menu_transition_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd56994a6694d1f3830b5ef89206446b3c600993 commit cd56994a6694d1f3830b5ef89206446b3c600993 Author: sczs <sczs@chromium.org> Date: Tue Jun 27 09:36:53 2017 [ios clean] Moves animator and presenters under transitions Moves the animator and presenters directories under the transition directory. This in order to consolidate everything related to transitions under the same directory. Also, some follow up comments from: https://codereview.chromium.org/2952213003/ BUG=682880 Review-Url: https://codereview.chromium.org/2955033002 Cr-Commit-Position: refs/heads/master@{#482584} [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/find_in_page/BUILD.gn [delete] https://crrev.com/8e8aa98f3b4b67412dc9d2a842d457f40b12caad/ios/clean/chrome/browser/ui/presenters/menu_presentation_delegate.h [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/root/BUILD.gn [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/root/root_container_view_controller.h [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/root/root_container_view_controller_unittest.mm [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab/BUILD.gn [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.h [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm [add] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/BUILD.gn [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/animators/BUILD.gn [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/animators/README.md [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/animators/zoom_transition_animator.h [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/animators/zoom_transition_animator.mm [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/animators/zoom_transition_delegate.h [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/presenters/BUILD.gn [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/presenters/README.md [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/presenters/menu_presentation_controller.h [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/presenters/menu_presentation_controller.mm [add] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/presenters/menu_presentation_delegate.h [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/zoom_transition_controller.h [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/zoom_transition_controller.mm [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/zooming_menu_transition_controller.h [rename] https://crrev.com/cd56994a6694d1f3830b5ef89206446b3c600993/ios/clean/chrome/browser/ui/transitions/zooming_menu_transition_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e1d5a7f990f06911ea848d97f4373619e2a35c7 commit 0e1d5a7f990f06911ea848d97f4373619e2a35c7 Author: sczs <sczs@chromium.org> Date: Thu Jul 06 09:22:57 2017 [ios clean] ToolsMediator Unittest followup Follow up from: https://codereview.chromium.org/2906313003/diff/60001/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm Bug: 682880 Change-Id: Ie972341e4b6cc12524e91bb382edf61a318c3141 Reviewed-on: https://chromium-review.googlesource.com/560719 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#484511} [modify] https://crrev.com/0e1d5a7f990f06911ea848d97f4373619e2a35c7/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f4e72264e43692b449220664f8686fcbb20b758 commit 5f4e72264e43692b449220664f8686fcbb20b758 Author: sczs <sczs@chromium.org> Date: Wed Jul 12 23:42:45 2017 [ios] Fixes total number of menu items. Updates the total number of menu items to reflect the fact that an item was deleted. Also added a comment in order to prevent this from happening again. Bug: 682880 Change-Id: I0893cd9e4eda6f1b7238cc2fcfe892d30a1cb42c Reviewed-on: https://chromium-review.googlesource.com/565175 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: Ed Chin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486156} [modify] https://crrev.com/5f4e72264e43692b449220664f8686fcbb20b758/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [modify] https://crrev.com/5f4e72264e43692b449220664f8686fcbb20b758/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm [modify] https://crrev.com/5f4e72264e43692b449220664f8686fcbb20b758/ios/clean/chrome/browser/ui/tools/tools_menu_model.h [modify] https://crrev.com/5f4e72264e43692b449220664f8686fcbb20b758/ios/clean/chrome/browser/ui/tools/tools_menu_model.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0825547dd2acbe7aea70481c992c4540ad918fbf commit 0825547dd2acbe7aea70481c992c4540ad918fbf Author: sczs <sczs@chromium.org> Date: Thu Jul 20 22:25:55 2017 [ios clean] Disables ToolsMenu items based on ToolsMenuConfig This CL disables certain items on the ToolsMenu based on the following criteria: -No Tabs Opened. (Will disable Close All Tabs/Incognito Tabs) -In New Tab Page. (Will disable Find in Page and Request Desktop/Mobile sites). In order to do this a new Bitmask is added to the ToolsMenuModel and it is used by the ToolsMediator to check if the item should be enabled or not. Bug: 682880 Change-Id: I2318f7c3d6308317cb9c07e6b5a4692a4fdd9a5e Reviewed-on: https://chromium-review.googlesource.com/571922 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#488442} [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/tools_mediator.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/tools_menu_item.h [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/tools_menu_item.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/tools_menu_model.h [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/clean/chrome/browser/ui/tools/tools_menu_model.mm [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.h [modify] https://crrev.com/0825547dd2acbe7aea70481c992c4540ad918fbf/ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbad163901eb19d04992411cbc27b3923fe30b5e commit bbad163901eb19d04992411cbc27b3923fe30b5e Author: sczs <sczs@chromium.org> Date: Sat Jul 29 03:48:00 2017 [ios] Moves tools_menu files from shared to chrome. Bug: 682880 Change-Id: I0429e93e66d09e97309a9a2bed04477eeaa39a9b Reviewed-on: https://chromium-review.googlesource.com/587870 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#490612} [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/stack_view/BUILD.gn [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/stack_view/stack_view_controller.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/toolbar/toolbar_controller.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/BUILD.gn [rename] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/tools_menu_configuration.h [rename] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/tools_menu_configuration.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/tools/BUILD.gn [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/tools/tools_mediator.mm [modify] https://crrev.com/bbad163901eb19d04992411cbc27b3923fe30b5e/ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm [delete] https://crrev.com/97e7f7fd46699c8feb959534fcd0976625856325/ios/shared/chrome/browser/ui/tools_menu/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Jan 21 2017