Download backend alerts about in-progress downloads with 0 seconds remaining when they start |
||||
Issue descriptionWhen a download starts, the download is marked as in-progress but there's no time set. This results in the status string flashing "0 seconds remaining" to "59 seconds remaining" (e.g.) when a download starts. I worked around this in Download Home by making it say "Downloading..." when it gets into this state but it's not a great solution because you can also have 0 seconds remaining when the file is nearly completely downloaded.
,
Jan 24 2017
Comment from Min on blocked bug: One thing about the remaining time is that what if the download progress is reaching 100%. In that case, showing a 0 sec is possible if the network speed is very fast. Transition from "1 sec" in time remaining to "downloading..." in that case feels a little wierd. Not sure what is the best string for this, maybe we should recalculate the remaining time by using previous information (remaining_size * time_passed/data_downloaded) in this case. Shakti can you take a look at this? I think the main concern is how we handle this for downloads finishing and moving to "Downloading..." Let's discuss at today's status. Adding relevant parties as well.
,
Jan 24 2017
OK, here is what I think we should do. Please yell if this doesn't sound right. If we don't know how much time remains at the beginning of the download, we should display "Downloading." Rachel, I don't think we should use "download pending" as you suggested in comment 64 of the blocked bug because we don't typically use that string for most file downloads (correct me if I am wrong). "Downloading" is also more accurate because that is what is happening at the system level. The key is that we don't want to change the 0 seconds remaining at the end of a download. That should remain 0 seconds since it is likely accurate at that point. If that is not possible today because we are just doing a if str=="0 seconds remaining" then setStr=="Downloading", then we do need to do something similar to what Min suggested. To my knowledge, this bug is scoped to both the notifications and the downloads home on Android.
,
Jan 25 2017
Thanks Jon, that sounds good to me.
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a1f62791cf3be6eaca850d90518fe2436b5a94c commit 0a1f62791cf3be6eaca850d90518fe2436b5a94c Author: shaktisahu <shaktisahu@chromium.org> Date: Wed Jan 25 20:26:17 2017 [Download Home] Fix for 0 seconds remaining Download backend is not able to compute the time remaining when download is started/paused/resumed. In those cases, currently it returns 0 which causes confusion to the UI. This CL proposes to return -1 in those cases and which can be easily distinguished from a valid 0 seconds remaining message. BUG= 682865 Review-Url: https://codereview.chromium.org/2647343005 Cr-Commit-Position: refs/heads/master@{#446106} [modify] https://crrev.com/0a1f62791cf3be6eaca850d90518fe2436b5a94c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java [modify] https://crrev.com/0a1f62791cf3be6eaca850d90518fe2436b5a94c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/0a1f62791cf3be6eaca850d90518fe2436b5a94c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/0a1f62791cf3be6eaca850d90518fe2436b5a94c/chrome/browser/android/download/download_manager_service.cc
,
Feb 6 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dfalcant...@chromium.org
, Jan 23 2017