DCEHCK in ~CdmPromiseAdapter() when destructing MojoCdm |
||||||
Issue description01-19 15:04:07.720 17535 17558 F chromium: [FATAL:cdm_promise_adapter.cc(15)] Check failed: promises_.empty(). 0012e831 media::CdmPromiseAdapter::~CdmPromiseAdapter() /usr/local/google/workspace/clank/src/media/base/cdm_promise_adapter.cc:15 00baac03 media::MojoCdm::~MojoCdm() /usr/local/google/workspace/clank/src/media/mojo/clients/mojo_cdm.cc:73 00baad21 media::MojoCdm::~MojoCdm() /usr/local/google/workspace/clank/src/media/mojo/clients/mojo_cdm.cc:86 v------> base::RefCountedThreadSafe<media::ContentDecryptionModule, media::ContentDecryptionModuleTraits>::Release() const /usr/local/google/workspace/clank/src/base/memory/ref_counted.h:185 v------> scoped_refptr<media::ContentDecryptionModule>::Release(media::ContentDecryptionModule*) /usr/local/google/workspace/clank/src/base/memory/ref_counted.h:409 v------> scoped_refptr<media::ContentDecryptionModule>::~scoped_refptr() /usr/local/google/workspace/clank/src/base/memory/ref_counted.h:311 0001acd1 media::CdmSessionAdapter::~CdmSessionAdapter() /usr/local/google/workspace/clank/src/media/blink/cdm_session_adapter.cc:34 v------> base::RefCounted<media::CdmSessionAdapter>::Release() const /usr/local/google/workspace/clank/src/base/memory/ref_counted.h:135 v------> scoped_refptr<media::CdmSessionAdapter>::Release(media::CdmSessionAdapter*) /usr/local/google/workspace/clank/src/base/memory/ref_counted.h:409 v------> scoped_refptr<media::CdmSessionAdapter>::~scoped_refptr() /usr/local/google/workspace/clank/src/base/memory/ref_counted.h:311 0002f02b media::WebContentDecryptionModuleSessionImpl::~WebContentDecryptionModuleSessionImpl() /usr/local/google/workspace/clank/src/media/blink/webcontentdecryptionmodulesession_impl.cc:257 0002f075 media::WebContentDecryptionModuleSessionImpl::~WebContentDecryptionModuleSessionImpl() /usr/local/google/workspace/clank/src/media/blink/webcontentdecryptionmodulesession_impl.cc:279 v------> std::__ndk1::default_delete<blink::WebContentDecryptionModuleSession>::operator()(blink::WebContentDecryptionModuleSession*) const /usr/local/google/workspace/clank/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2431 v------> std::__ndk1::unique_ptr<blink::WebContentDecryptionModuleSession, std::__ndk1::default_delete<blink::WebContentDecryptionModuleSession> >::reset(blink::WebContentDecryptionModuleSession*) /usr/local/google/workspace/clank/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630 00390bd3 blink::MediaKeySession::contextDestroyed(blink::ExecutionContext*) ....
,
Jan 20 2017
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc12d84bae452abfef8e6e110908305ad5401a77 commit fc12d84bae452abfef8e6e110908305ad5401a77 Author: xhwang <xhwang@chromium.org> Date: Fri Jan 20 18:14:43 2017 media: Reject promises and close sessions in MojoCdm destructor This was missed in the original CL at 0d5d318987dde8b. BUG= 671362 , 682863 TEST=new test added Review-Url: https://codereview.chromium.org/2638403005 Cr-Commit-Position: refs/heads/master@{#445093} [modify] https://crrev.com/fc12d84bae452abfef8e6e110908305ad5401a77/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/fc12d84bae452abfef8e6e110908305ad5401a77/media/mojo/clients/mojo_cdm_unittest.cc
,
Jan 20 2017
This needs to be merged to M57 given it might just missed the branch cut.
,
Jan 23 2017
,
Jan 25 2017
,
Jan 25 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/360a7fda6014a54cac1c40aed6548a52b90ae0ca commit 360a7fda6014a54cac1c40aed6548a52b90ae0ca Author: xhwang <xhwang@chromium.org> Date: Wed Jan 25 21:49:41 2017 media: Reject promises and close sessions in MojoCdm destructor This was missed in the original CL at 0d5d318987dde8b. NOTRY=true NOPRESUBMIT=true TBR=jrummell@chromium.org BUG= 671362 , 682863 TEST=new test added Review-Url: https://codereview.chromium.org/2638403005 Cr-Commit-Position: refs/heads/master@{#445093} (cherry picked from commit fc12d84bae452abfef8e6e110908305ad5401a77) Review-Url: https://codereview.chromium.org/2656833003 Cr-Commit-Position: refs/branch-heads/2987@{#96} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/360a7fda6014a54cac1c40aed6548a52b90ae0ca/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/360a7fda6014a54cac1c40aed6548a52b90ae0ca/media/mojo/clients/mojo_cdm_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xhw...@chromium.org
, Jan 20 2017