New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 664704



Sign in to add a comment

Network grid should preserve sorting while requests stream in

Project Member Reported by allada@chromium.org, Jan 19 2017

Issue description

Network log should sort items while they are being received not just a 1 time sort and then append new items to the bottom of the grid.
 

Comment 1 by allada@chromium.org, Jan 20 2017

Blocking: 664704
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4bf390cfc5619a04b3b67fdc9930234e407fea

commit 1c4bf390cfc5619a04b3b67fdc9930234e407fea
Author: allada <allada@chromium.org>
Date: Sat Jan 21 00:51:32 2017

[Devtools] Fixed network to sort items as they are received.

This patch fixes a bug where if an item is received in network panel it
was always puting it at the bottom even if it was not sorted in that
manner. This patch re-sorts the grid properly.

This patch also handles the preservation of the sriping by anchoring it
to the top item in the list (keeps the strips from flipping if items are
received and put above your current view port list).

R=dgozman,luoe,caseq
BUG= 682861 

Review-Url: https://codereview.chromium.org/2647803002
Cr-Commit-Position: refs/heads/master@{#445232}

[modify] https://crrev.com/1c4bf390cfc5619a04b3b67fdc9930234e407fea/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
[modify] https://crrev.com/1c4bf390cfc5619a04b3b67fdc9930234e407fea/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/1c4bf390cfc5619a04b3b67fdc9930234e407fea/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/1c4bf390cfc5619a04b3b67fdc9930234e407fea/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Status: Fixed (was: Assigned)

Sign in to add a comment