New issue
Advanced search Search tips

Issue 682853 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crash when cancelling a job sent to an unreachable printer

Project Member Reported by skau@chromium.org, Jan 19 2017

Issue description

What steps will reproduce the problem?
(1) Start print job
(2) Walk across the building/turn off wifi
(3) Cancel print job

What is the expected result?
Print job cancels.

What happens instead?
Browser crash
 

Comment 1 by skau@chromium.org, Feb 15 2017

Cc: skau@chromium.org
Issue 692738 has been merged into this issue.

Comment 2 by skau@chromium.org, Feb 22 2017

If a job is cancelled by the printer, attempting to use cancel will also crash.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6157021217dd1922d6f5dcc8fd00b6e36bbb3a32

commit 6157021217dd1922d6f5dcc8fd00b6e36bbb3a32
Author: skau <skau@chromium.org>
Date: Wed Feb 22 23:51:45 2017

Use job id from JobEventDetails to create CupsPrintJobs.

By using job id from JobEventDetails, we can avoid querying CUPS to
display the initial notification and we don't have to guess if we've
identified the correct job.  This wasn't done originally, because job id
was not present in JobEventDetails.

Additionally, add some rate limiting for queries and check for jobs which
we lose track of.

Speculatively, this fixes 682853 as cupsd can become overwhelmed and stop responding to queries.

BUG= 684853 , 682853 

Review-Url: https://codereview.chromium.org/2699273002
Cr-Commit-Position: refs/heads/master@{#452281}

[modify] https://crrev.com/6157021217dd1922d6f5dcc8fd00b6e36bbb3a32/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[modify] https://crrev.com/6157021217dd1922d6f5dcc8fd00b6e36bbb3a32/chrome/browser/chromeos/printing/cups_print_job_manager_impl.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d49127cc30716341b904fd9cfc6e26e68b6d5d

commit b5d49127cc30716341b904fd9cfc6e26e68b6d5d
Author: skau <skau@chromium.org>
Date: Sat Feb 25 00:48:24 2017

Report print jobs that are cancelled by CUPS as errors.

If a print job encounters a problem, it can sometimes be cancelled by
CUPS or the printer.  We will now notify the user of an error in this
situation.  If a user cancels a print job, the behavior remains the same.

BUG= 682853 , 684853 

Review-Url: https://codereview.chromium.org/2708233006
Cr-Commit-Position: refs/heads/master@{#453025}

[modify] https://crrev.com/b5d49127cc30716341b904fd9cfc6e26e68b6d5d/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/b5d49127cc30716341b904fd9cfc6e26e68b6d5d/chrome/browser/chromeos/printing/cups_print_job_notification.h
[modify] https://crrev.com/b5d49127cc30716341b904fd9cfc6e26e68b6d5d/chrome/browser/chromeos/printing/cups_print_job_notification_manager.cc
[modify] https://crrev.com/b5d49127cc30716341b904fd9cfc6e26e68b6d5d/chrome/browser/chromeos/printing/cups_print_job_notification_manager.h

Comment 5 by skau@chromium.org, Feb 28 2017

Status: Fixed (was: Untriaged)

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by skau@chromium.org, Apr 21 2017

Issue 707718 has been merged into this issue.

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment