Get Help: add managed device signal |
|||||||||||||
Issue descriptionSimilarly to how the playstore signal was added recently to the Get Help app, also add a signal for managed devices. This signal will be able to be read by gKMS/Redwood for Get Help articles, should the need arise, as well allow such devices to be tracked for Get Help metrics.
,
Feb 2 2017
Colin, could you pick this up after you are done with your notification bug? This is kinda important to get into M58 and shouldn't take very much time.
,
Feb 2 2017
Sure, I'll look into this.
,
Feb 2 2017
,
Feb 9 2017
Adding myself to this ticket since Colin will pass it to me to follow up on his ChromeOS updates with correlating Get Help app changes.
,
Feb 13 2017
I've done with the actual codes but need to have more tests. Ready soon.
,
Feb 13 2017
,
Feb 13 2017
,
Feb 13 2017
Hi Colin. You can assign this ticket to me when your work is completed and tested. Then I'll make related updates to Get Help app. Thanks.
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3777167162feb5b4fbd24e8386e92ae92fe354c8 commit 3777167162feb5b4fbd24e8386e92ae92fe354c8 Author: wzang <wzang@chromium.org> Date: Wed Feb 22 20:55:55 2017 Add managed device signal (managed or not managed). It'll be used by the Get Help app. Use fake install attributes for browser tests. BUG= 682837 Review-Url: https://codereview.chromium.org/2686233006 Cr-Commit-Position: refs/heads/master@{#452193} [modify] https://crrev.com/3777167162feb5b4fbd24e8386e92ae92fe354c8/chrome/browser/chromeos/extensions/info_private_api.cc [modify] https://crrev.com/3777167162feb5b4fbd24e8386e92ae92fe354c8/chrome/browser/chromeos/extensions/info_private_apitest.cc [modify] https://crrev.com/3777167162feb5b4fbd24e8386e92ae92fe354c8/chrome/common/extensions/api/chromeos_info_private.json [modify] https://crrev.com/3777167162feb5b4fbd24e8386e92ae92fe354c8/chrome/test/data/extensions/api_test/chromeos_info_private/basic/background.js [modify] https://crrev.com/3777167162feb5b4fbd24e8386e92ae92fe354c8/chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
,
Feb 22 2017
,
Feb 23 2017
This is fixed. The signal is available from the Chrome OS info private API now as of 452193. Keep in mind, we haven't uprev'ed Chrome in a few days, so the change hasn't shown up on the Chrome OS canary yet but will, with the very next uprev (whenever that is).
,
Mar 3 2017
,
Mar 3 2017
,
Jan 22 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by st...@chromium.org
, Jan 23 2017