New issue
Advanced search Search tips

Issue 682823 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 603386


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

MacViews: Intrinsic size of Edit Bookmarks feels too narrow

Project Member Reported by rsesek@chromium.org, Jan 19 2017

Issue description

Chrome Version: 57.0.2984.0
OS: macOS 10.11.6

What steps will reproduce the problem?
(1) Enable --secondary-ui-md
(2) Right click on a bookmark, select "Edit Bookmark"
(3) Note the size of the sheet

What is the expected result?
The sheet feels too narrow and too tall. I can't resize the sheet to be less tall, but increasing the width feels better. I attached screenshots as a comparison.

What happens instead?
I file a very subjective bug.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Screen Shot 2017-01-19 at 1.35.51 PM.png
630 KB View Download
Screen Shot 2017-01-19 at 1.36.03 PM.png
879 KB View Download

Comment 1 by tapted@chromium.org, Jan 19 2017

Blocking: 603386
Cc: tapted@chromium.org
Components: Internals>Views
Labels: -Pri-3 Phase3 M-58 Pri-2
Status: Available (was: Untriaged)
There's something weird to investigate here. My default size is quite wide (approx 770x430 pixels), and I can't make it smaller.

Harmony has a spec for "standard" dialog sizes (like, one of three standard widths -- I need to hunt down the slide) - we should pick one of those.
Labels: MacViews-Dialogs

Comment 3 by tapted@chromium.org, Jun 27 2017

Cc: ellyjo...@chromium.org
Status: WontFix (was: Available)
I think this is a fixed or wontfix. The dialog isn't resizable on other platforms, and it conflicts with the fixed-width deal in Harmony. Nobody's _complained_ about this dialog being resizable on Mac, and it's not broken, so I suppose it can stay resizable.

The dialog sets a preferred client view size of 70 "characters" wide and 25 "lines" tall. For me (after adding the non-client view: buttons/titles/etc) this is 477x400 pixels (it would have been more, but elly fixed that in r469336), which BubbleFrameView now rounds up to 512 pixels.

The minimum width of the dialog comes from the buttons and padding. For me this is 336 pixels (depends on the button labels, which depends on language). That's more than 320, so it would be rounded up to 448px, even if we picked something smaller than 70 characters wide.

There's no rounding for the dialog height, so in most cases this should end up wider since this bug was filed. i.e. less narrow.

One possible improvement would be to allow the dialog to be user-resized to be smaller than its default width. That's easy to do (the dialog delegate just needs to return a result for GetMinimumSize() as well as the preferred size). But it would involve admitting that this dialog is resizable on mac when it probably shouldn't be..

We could also say "we don't want 25 lines on Mac, but 20", but with the new widths I think this is fine.

Sign in to add a comment