New issue
Advanced search Search tips

Issue 682816 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 58-Dev , 58-Beta , 58-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Remove pre-standard ChaCha20-Poly1305 ciphers

Project Member Reported by davidben@chromium.org, Jan 19 2017

Issue description

See http://www.chromium.org/blink#launch-process for an overview of the
Blink launch process.

This launch issue is used for standards and implementation tracking only,
not for Chrome approval regarding privacy, security, legal, UI, testing,
accessibility etc. If your feature requires approval in any of those areas
please additionally create a Type=Launch issue (note you will most likely
want a PM to guide you through the Type=Launch process, guidance can be
found at go/newchromefeature)

---

Change description:
Remove pre-standard variants of ChaCha20-Poly1305 cipher suites. The standardized variants were shipped at the start of 2016.

Changes to API surface:
No longer advertise OLD_TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 and OLD_TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256.

Links:
Public standards discussion: https://tools.ietf.org/html/rfc7905

Support in other browsers:
Internet Explorer: no support (i.e. removal matches)
Firefox: no support (i.e. removal matches)
Safari: no support (i.e. removal matches)

*Make sure to fill in any labels with a -?, including all OSes this change
affects. Feel free to leave other labels at the defaults.

 
Labels: -M-57 -Launch-M-Target-57-Dev -Launch-M-Target-57-Beta -Launch-M-Target-57-Stable M-58 Launch-M-Target-58-Dev Launch-M-Target-58-Beta Launch-M-Target-58-Stable
Sorry, I meant 58, not 57. Off by one.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl.git/+/2e839244b078205ff677ada3fb83cf9d60ef055b

commit 2e839244b078205ff677ada3fb83cf9d60ef055b
Author: Adam Langley <agl@google.com>
Date: Thu Jan 19 23:12:44 2017

Remove old ChaCha20-Poly1305 AEAD.

Before RFC 7539 we had a ChaCha20-Poly1305 cipher suite that had a 64/64
nonce/counter split (as DJB's original ChaCha20 did). RFC 7539 changed
that to 96/32 and we've supported both for some time.

This change removes the old version and the TLS cipher suites that used
it.

BUG= chromium:682816 

Change-Id: I2345d6db83441691fe0c1ab6d7c6da4d24777849
Reviewed-on: https://boringssl-review.googlesource.com/13203
Reviewed-by: Adam Langley <agl@google.com>

[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/crypto/cipher/aead_test.cc
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/crypto/cipher/e_chacha20poly1305.c
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/crypto/cipher/test/chacha20_poly1305_tests.txt
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/include/openssl/aead.h
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/include/openssl/tls1.h
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/internal.h
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/ssl_cipher.c
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/ssl_test.cc
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/test/runner/chacha20_poly1305.go
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/test/runner/chacha20_poly1305_test.go
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/test/runner/cipher_suites.go
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/ssl/test/runner/runner.go
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/tool/speed.cc
[modify] https://crrev.com/2e839244b078205ff677ada3fb83cf9d60ef055b/util/all_tests.json

Comment 3 by awhalley@google.com, May 10 2017

Cc: awhalley@chromium.org

Comment 4 by awhalley@google.com, May 10 2017

Status: Fixed (was: Assigned)
This went out in M58, closing.

Sign in to add a comment