New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682802 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Strict mode violation in WebApkInstaller#installDownloadedWebApk()

Project Member Reported by pkotw...@chromium.org, Jan 19 2017

Issue description

Strict mode violation in WebApkInstaller#installDownloadedWebApk()

The strict mode violation seems to be caused by ContentUriUtils#getContentUriFromFile()



 
Cc: gonzalon@chromium.org
This bug was causing Chrome to crash. The call to ChromeStrictMode#addThreadDeathPenalty() in particular
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40b86413cfabfcb66588b7d6f5fe430c19403659

commit 40b86413cfabfcb66588b7d6f5fe430c19403659
Author: fgorski <fgorski@chromium.org>
Date: Wed Mar 01 17:56:31 2017

[Offline pages] Implementation of OfflineBackgroundTask using background_task_scheduler

This patch makes updates to offline pages background scheduling to
enabel use of background_task_scheduler when scheduling for M+ (using JobScheduler):
* BackgroundJobScheduler uses the new component to schedule task,
* BackgroundOfflinerTask#startBackgroundRequest is refactored to
  enable handling both JobScheduler, and GCMNetworkManager task
  handling.
* Implementation is provided in:
  BackgroundOfflinerTask#startBackgroundRequestImpl
* BackgroundSchedulerBridge adds a method to stopProcessing
* The call is passed to RequestCoordinator, using a newly added
  Offliner::RequestStatus::BACKGROUND_SCHEDULER_CANCELED
* Handling of PersistableBundle is removed from TaskExtrasPacker
  as this functionality is handled by background_task_scheduler

BUG= 682802 
R=petewil@chromium.org,nyquist@chromium.org
TBR=holte@chromium.org

Review-Url: https://codereview.chromium.org/2697493002
Cr-Commit-Position: refs/heads/master@{#453966}

[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundJobScheduler.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java
[delete] https://crrev.com/eddd0d4f361b16d62eae38b198d6cedde1626186/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerJobService.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerProcessorImpl.java
[add] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTask.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPacker.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/interfaces/BackgroundSchedulerProcessor.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/java_sources.gni
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/chrome/browser/android/offline_pages/background_scheduler_bridge.cc
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/components/offline_pages/core/background/request_coordinator_event_logger.cc
[modify] https://crrev.com/40b86413cfabfcb66588b7d6f5fe430c19403659/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Untriaged)
The patch in #2 looks unrelated but this code (DownloadWebApk) was deleted so closing

Sign in to add a comment