New issue
Advanced search Search tips

Issue 682801 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix ASAN instrumented unittests and buildbot

Project Member Reported by etienneb@chromium.org, Jan 19 2017

Issue description

Some unittests are not running on the ASAN memory bots:
  https://cs.chromium.org/chromium/src/testing/buildbot/chromium.memory.full.json?sq=package:chromium&dr&l=232

(i.e. pdfium_unittests, ...)


These unittests are crashing or have a invalid memory accesses.

~/chromium/src$ out/asan64/flatbuffers_unittest 
TEST FAILED: ../../third_party/flatbuffers/src/tests/test.cpp:275, flatbuffers::LoadFile( "tests/monster_test.fbs", false, &schemafile) (0) != 1
TEST FAILED: ../../third_party/flatbuffers/src/tests/test.cpp:277, flatbuffers::LoadFile( "tests/monsterdata_test.golden", false, &jsonfile) (0) != 1
TEST FAILED: ../../third_party/flatbuffers/src/tests/test.cpp:290, VerifyMonsterBuffer(verifier) (0) != 1
=================================================================
==25476==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x619000000980 at pc 0x00000056271a bp 0x7ffd75bd0b60 sp 0x7ffd75bd0b58
READ of size 4 at 0x619000000980 thread T0
    #0 0x562719  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x562719)
    #1 0x520782  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x520782)
    #2 0x533350  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x533350)
    #3 0x7f841cfa6f44  (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)

0x619000000980 is located 0 bytes to the right of 1024-byte region [0x619000000580,0x619000000980)
allocated by thread T0 here:
    #0 0x512260  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x512260)
    #1 0x51867e  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x51867e)
    #2 0x520e89  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x520e89)
    #3 0x5204fc  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x5204fc)
    #4 0x533350  (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x533350)
    #5 0x7f841cfa6f44  (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)

SUMMARY: AddressSanitizer: heap-buffer-overflow (/usr/local/google/home/etienneb/chromium/src/out/asan64/flatbuffers_unittest+0x562719) 
Shadow bytes around the buggy address:
  0x0c327fff80e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff80f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff8100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff8110: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff8120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c327fff8130:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c327fff8140: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c327fff8150: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff8160: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff8170: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c327fff8180: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==25476==ABORTING
 

Comment 2 by no...@chromium.org, Jun 2 2018

Components: -Infra>Platform>Buildbot Infra>Client>Chrome

Sign in to add a comment