https://codereview.chromium.org/2644133003/ contains proposed patch

Deleted: Screenshot_20170119-205441[1].png 116 KB

	Screenshot_20170119-205441[1].png 116 KB View Download

fgorski / palmer: I don't know what we want to do here. Could you help out?

This is lgarron's purview

Patch disables info with error pages, which is the most sensible (doesn't add new strings, etc.). Is there any problem with it ?

> Is there any problem with it ?

Yeah, we should make sure Page Info always shows something useful and correct.
This bug also applies to desktop.

From a pure UI perspective, I think a better solution for net errors would be to replace the security summary with something like "This site cannot be reached".

The proposed CL seems to talk about offline pages. Is this bug meant to be about saved offline pages?

offline pages -> patch doesn't change anything and show info, that page is in offline version taken on ... day

error pages -> empty (once again: we don't add new string, etc. and I don't want to have info, that this is secure internal Chrome page, because it will be making confusion)

Chrome internal pages -> patch doesn't change anything (there is info, that this is secure internal page)

other -> http/https info

If we really need info, I will add it; but please precise it :)

hi,

can I ask for any decision/comment/update here ?

hi,

Three people involved and since Jan 19 in fact no voice against. Can we have LGTM ?

I'm opposed to making this change only in Android.

However, if you get UI's guidance and permission for doing this on all platforms, I would not be opposed to a cross-platform change.

rolfe@: Do you know who on UI is appropriate for Page Info nowadays?

+ maxwalker@ is your go-to!

So, you'd like to include net-error info in PageInfo in the case of a neterror?

This seems reasonable to me, we'll need to think about what strings make the most sense.

Security page status cannot be determined/checked in this moment ?

lgarron / emilyschechter: Any updates here?

Similar case (not duplicate): https://bugs.chromium.org/p/chromium/issues/detail?id=786833

 Issue 786833  has been merged into this issue.

Nothing is happening here and I wanted to propose https://chromium-review.googlesource.com/c/chromium/src/+/1088700.

Can we resume discussion?

Deleted: Screenshot_20180606-150007.png 118 KB

	Screenshot_20180606-150007.png 118 KB View Download

Based on comment #16, it sounds like we need a finalized string. +srahim@ is our strings expert.

thx Theresa. srahim@, WDYT about #27?

lzbylut@, could you look on it please and decide if you could help with this?

Thank you for bringing this thread to my attention. 

I agree with Emily's Comment 16, that the current string displayed in site info is not accurate when the website cannot be reached due to a network error - like when the user if offline. 

However, I disagree with the proposal in Comment 16 - is it broad and potentially inaccurate. I am open to the proposal in Comment 2, but I generally do not like that the site info text box is empty.

I will consult with Emily and security leads to understand the preferred solution. Please hold off on submitting additional changes until we can advise on the proper approach.