New issue
Advanced search Search tips

Issue 682780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Need escape hatch when device reboots to get out of kiosk mode

Project Member Reported by vidster@chromium.org, Jan 19 2017

Issue description

Escape hatch (CTRL + Alt +S → to get out of Kiosk mode)

 
Components: UI>Shell>Kiosk>ARC
Labels: -M-56 M-57
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7

commit af6c8bbf83b31deb1a772193dff2ff2871f4fbd7
Author: poromov <poromov@chromium.org>
Date: Fri Feb 03 21:38:32 2017

arc: Add splash screen for ARC++ Kiosk startup

Implemented similar to App Launch Splash Screen that is used for Chrome Kiosk.

Splash screen is shown immediately after launching ARC++ Kiosk session
and destructed when app window is launched. This leads to no UI exposed,
except to sign in screen, splash screen and finally app window.

User can escape launching of the app by pressing Ctrl+Alt+S during the splash
screen.

Also fixes bug of restarting app few seconds after launch.

BUG=682778, 682780 ,	681111,677310
TEST=Manual, Start ARC++ Kiosk sessions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649103006
Cr-Commit-Position: refs/heads/master@{#448075}

[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/arc_kiosk_controller.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_actor.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/oobe_screens.html
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.css
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.html
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.js
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc
[add] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/ui/login/display_manager.js
[modify] https://crrev.com/af6c8bbf83b31deb1a772193dff2ff2871f4fbd7/ui/login/screen_container.css

Status: Fixed (was: Assigned)
After this CL landed the splash screen should be shown for at least 3 seconds (may be more)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 10 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3e555a3952276620ae2274a6707ff49357ed0f

commit 9a3e555a3952276620ae2274a6707ff49357ed0f
Author: Sergey Poromov <poromov@chromium.org>
Date: Fri Feb 10 11:03:30 2017

arc: Add splash screen for ARC++ Kiosk startup

Implemented similar to App Launch Splash Screen that is used for Chrome Kiosk.

Splash screen is shown immediately after launching ARC++ Kiosk session
and destructed when app window is launched. This leads to no UI exposed,
except to sign in screen, splash screen and finally app window.

User can escape launching of the app by pressing Ctrl+Alt+S during the splash
screen.

Also fixes bug of restarting app few seconds after launch.

BUG=682778, 682780 ,	681111,677310
TEST=Manual, Start ARC++ Kiosk sessions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649103006
Cr-Commit-Position: refs/heads/master@{#448075}
(cherry picked from commit af6c8bbf83b31deb1a772193dff2ff2871f4fbd7)

Review-Url: https://codereview.chromium.org/2691493002 .
Cr-Commit-Position: refs/branch-heads/2987@{#432}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.h
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/arc_kiosk_controller.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_actor.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/oobe_screens.html
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.css
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.html
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.js
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc
[add] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/ui/login/display_manager.js
[modify] https://crrev.com/9a3e555a3952276620ae2274a6707ff49357ed0f/ui/login/screen_container.css

Sign in to add a comment