Issue metadata
Sign in to add a comment
|
Regression: Two different tabtitle are appearing on the tab, when opening a NewTabPage |
||||||||||||||||||||||
Issue descriptionChrome Version: Chrome 57.0.2986.0 canary (64-bit) OS: Mac OS 10.12.2 What steps will reproduce the problem? (1) open a new tab (2) take a look at the tabtitle while the tab is generating in the Tabstrip What is the expected result? What happens instead? The title should only be "New Tab", but before the title "New Tab" appears, there appears "Unknown" as the tabtitle. Please use labels and text to provide additional information. Two screencast are attached. This seems to be a regression. It works fine in Chrome Stable. If you need more information, please let me know. Thanks. Mehmet
,
Jan 19 2017
Okay, I think this could broke it: https://codereview.chromium.org/2634333003 jam@: Can you please check, if your change from https://codereview.chromium.org/2634333003 is causing this issue? Thanks in advance.
,
Jan 20 2017
,
Jan 20 2017
,
Jan 20 2017
Using the per-revision bisect providing the bisect results, Good build:57.0.2984.0(Revision:443964) Bad build: 57.0.2986.0(Revision:444600) You are probably looking for a change made after 444581 (known good), but no later than 444582 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/098f72afae1133c762650b2c841981be9b4afe6e..8f2edb19b97abef9598d3b602ed3740e78b9230e From the CL above, This indeed looks jam's change https://codereview.chromium.org/2634333003 Note : Adding ReleaseBlock-Stable for now, please feel free to add/edit this. Thanks!
,
Jan 20 2017
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1c7a2ae38ea453f101480ab91ee98e6acebf56f commit b1c7a2ae38ea453f101480ab91ee98e6acebf56f Author: jam <jam@chromium.org> Date: Fri Jan 20 15:12:45 2017 Fix flickering in new tab title after r444582. DidStartNavigation is called too late to prevent flickering with PlzNavigate disabled. So bring back overriding of DidStartNavigationToPendingEntry for the non-PlzNavigate case. BUG= 682774 Review-Url: https://codereview.chromium.org/2644963004 Cr-Commit-Position: refs/heads/master@{#445055} [modify] https://crrev.com/b1c7a2ae38ea453f101480ab91ee98e6acebf56f/chrome/browser/ui/search/search_tab_helper.cc [modify] https://crrev.com/b1c7a2ae38ea453f101480ab91ee98e6acebf56f/chrome/browser/ui/search/search_tab_helper.h
,
Jan 20 2017
,
Jan 20 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 23 2017
Cl listed at #7 is {#445055} and M57 is branched Chromium at revision {#444943}, so merge is needed to M57. Hence, adding Merge-Request-57.
,
Jan 23 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2017
Please merge your change to M57 branch 2987 ASAP. So we can pick it for Dev release on Tuesday (02/24).
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a397c029afd7f52bcfd153bca4082872ef7332f2 commit a397c029afd7f52bcfd153bca4082872ef7332f2 Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Jan 23 18:46:55 2017 Fix flickering in new tab title after r444582. DidStartNavigation is called too late to prevent flickering with PlzNavigate disabled. So bring back overriding of DidStartNavigationToPendingEntry for the non-PlzNavigate case. BUG= 682774 Review-Url: https://codereview.chromium.org/2644963004 Cr-Commit-Position: refs/heads/master@{#445055} (cherry picked from commit b1c7a2ae38ea453f101480ab91ee98e6acebf56f) Review-Url: https://codereview.chromium.org/2652623003 . Cr-Commit-Position: refs/branch-heads/2987@{#30} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/a397c029afd7f52bcfd153bca4082872ef7332f2/chrome/browser/ui/search/search_tab_helper.cc [modify] https://crrev.com/a397c029afd7f52bcfd153bca4082872ef7332f2/chrome/browser/ui/search/search_tab_helper.h
,
Jan 24 2017
Verified the issue on Mac OS 10.12.2 using chrome dev M57 #57.0.2987.8 and issue is fixed. Title is only " New Tab" as the tab title for new tab pages. Attached screencast for reference. Adding TE-Verified Labels. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Jan 19 2017