New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682746 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Migrate gyp to PolyGerrit

Project Member Reported by aga...@chromium.org, Jan 19 2017

Issue description

Repos:
https://chromium.googlesource.com/external/gyp

Point of contact:
sdefresne@

Lists:
gyp-developer@googlegroups.com

Since this repo has had <1 commit per month in the last few months, I plan to immediately switch the default rather than leaving it enabled but behind a flag for a period of time.

Expected date of PSA: today, 19 Jan
Expected date of migration: Tuesday, 24 Jan
 

Comment 1 by aga...@chromium.org, Jan 20 2017

Status: Started (was: Assigned)
CL to set up CQ: https://chromium-review.googlesource.com/431094
CL to set ACLs: https://chromium-review.googlesource.com/430964
CL to set defaults: https://chromium-review.googlesource.com/431095
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/gyp/+/9733aa652da4da28cc65a95b12d4703c53789010

commit 9733aa652da4da28cc65a95b12d4703c53789010
Author: Aaron Gable <agable@chromium.org>
Date: Fri Jan 20 22:02:36 2017

Set up a CQ for gyp

BUG= 682746 

Change-Id: I37d5018820197f5dcdbcd0904caa251cd8d62f14
Reviewed-on: https://chromium-review.googlesource.com/431094
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[add] https://crrev.com/9733aa652da4da28cc65a95b12d4703c53789010/infra/config/cq.cfg
[modify] https://crrev.com/9733aa652da4da28cc65a95b12d4703c53789010/PRESUBMIT.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/gyp/+/a7055b3989c1074adca03b4b4829e7f0e57f6efd

commit a7055b3989c1074adca03b4b4829e7f0e57f6efd
Author: Aaron Gable <agable@chromium.org>
Date: Fri Jan 20 22:03:14 2017

Make Gerrit the default code review system for gyp

BUG= 682746 

Change-Id: I9d51f0d5e7186e9aa5faf4ae2758e32ab5785a12
Reviewed-on: https://chromium-review.googlesource.com/431095
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/a7055b3989c1074adca03b4b4829e7f0e57f6efd/codereview.settings

Comment 5 by aga...@chromium.org, Jan 24 2017

Status: Fixed (was: Started)
Changes landed, final PSA sent (to same thread).

Sign in to add a comment