New issue
Advanced search Search tips

Issue 682717 link

Starred by 1 user
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Jan 2017
Cc:
feature-...@grotations.appspotmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Extension id for Origin Trials is wrong.

Project Member Reported by iclell...@chromium.org, Jan 19 2017 
The extension id for the origin trials component is incorrect in the code; (and unfortunately, it's effectively random, we can't generate a correct component with this id.) This needs to be changed to the correct id so that we can properly push changes to OT configuration.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91822bd4b039b9151a54df63c387ae987e35fc59

commit 91822bd4b039b9151a54df63c387ae987e35fc59
Author: iclelland <iclelland@chromium.org>
Date: Thu Jan 19 20:52:13 2017

Fix Origin Trials configuration component id

BUG= 682717 

Review-Url: https://codereview.chromium.org/2642823007
Cr-Commit-Position: refs/heads/master@{#444841}

[modify] https://crrev.com/91822bd4b039b9151a54df63c387ae987e35fc59/chrome/browser/component_updater/origin_trials_component_installer.cc

Comment 2 by iclell...@chromium.org, Jan 20 2017

Status: Fixed (was: Started)

Comment 3 by iclell...@chromium.org, Jan 24 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 24 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Jan 24 2017 

Please merge your change to M57 branch 2987 ASAP so we can pick it up for this week dev release. Thank you.

Comment 6 by iclell...@chromium.org, Jan 24 2017 

My mistake -- this CL actually *made* the branch, by a couple of hours; I'll remove the Merge-* labels.

Comment 7 by iclell...@chromium.org, Jan 24 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-57
►

Sign in to add a comment