New issue
Advanced search Search tips

Issue 682692 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-config and handling of -lfdt

Project Member Reported by vapier@chromium.org, Jan 19 2017

Issue description

login_manager/login_manager.gyp now links against -lfdt manually.  there should be no need for that at all -- login_manager doesn't use fdt.h anywhere.

if libcros_config needs -lfdt, then it should be listed in its pc file.
 

Comment 2 by sjg@chromium.org, Jan 26 2017

Status: Assigned (was: Available)

Comment 3 by sjg@chromium.org, Feb 17 2017

Status: Started (was: Assigned)
https://chrome-internal-review.googlesource.com/#/c/310315/ is still not in :-(


I'm going to have a look anyway, as this is getting pretty old.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5d05e28051d262a5690e9555b743168f57245af8

commit 5d05e28051d262a5690e9555b743168f57245af8
Author: Simon Glass <sjg@chromium.org>
Date: Sat Feb 25 18:32:09 2017

login: Drop explicit mention of the fdt library

The fdt library should not be explicitly mentioned in the gyp file since
it is actually a dependency of chromeos-config. It was added to
chromeos-login because chromeos-config did not have its dependencies
correct. Now that this is fixed, we can drop it.

BUG= chromium:682692 
TEST=emerge-reef --unmerge chromeos-login dtc chromeos-config-tools
emerge-reef -q chromeos-login

Change-Id: I703b4744f9650d2c7ca8821f61ead73f0d32c63f
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/444820
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5d05e28051d262a5690e9555b743168f57245af8/login_manager/login_manager.gyp

Comment 5 by vapier@chromium.org, Feb 27 2017

Status: Fixed (was: Started)
thanks!

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment