chromeos-config and handling of -lfdt |
||||||||
Issue descriptionlogin_manager/login_manager.gyp now links against -lfdt manually. there should be no need for that at all -- login_manager doesn't use fdt.h anywhere. if libcros_config needs -lfdt, then it should be listed in its pc file.
,
Jan 26 2017
,
Feb 17 2017
https://chrome-internal-review.googlesource.com/#/c/310315/ is still not in :-( I'm going to have a look anyway, as this is getting pretty old.
,
Feb 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5d05e28051d262a5690e9555b743168f57245af8 commit 5d05e28051d262a5690e9555b743168f57245af8 Author: Simon Glass <sjg@chromium.org> Date: Sat Feb 25 18:32:09 2017 login: Drop explicit mention of the fdt library The fdt library should not be explicitly mentioned in the gyp file since it is actually a dependency of chromeos-config. It was added to chromeos-login because chromeos-config did not have its dependencies correct. Now that this is fixed, we can drop it. BUG= chromium:682692 TEST=emerge-reef --unmerge chromeos-login dtc chromeos-config-tools emerge-reef -q chromeos-login Change-Id: I703b4744f9650d2c7ca8821f61ead73f0d32c63f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/444820 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5d05e28051d262a5690e9555b743168f57245af8/login_manager/login_manager.gyp
,
Feb 27 2017
thanks!
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sjg@chromium.org
, Jan 19 2017