New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682673 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Security



Sign in to add a comment

CSP bypass with * host in source expressions

Project Member Reported by arthurso...@chromium.org, Jan 19 2017

Issue description

Chrome Version: 55.0.2883.87 (Official Build) (64-bit)
OS: All

There is some problems when the CSPSource host-part is "*".
For instance when the source-expression is:
* "http://*:111"  then "http://a.com:222" is allowed.
* "http://*/path" then "http://a.com/other-path" is allowed.
 
Labels: -Type-Bug Type-Bug-Security
Labels: Security_Impact-Stable

Comment 3 by est...@chromium.org, Jan 23 2017

Labels: Security_Severity-Low

Comment 4 by est...@chromium.org, Jan 23 2017

Summary: CSP bypass with * host in source expressions (was: Content-Security-Policy - )
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Pri-1 Pri-2
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8b6c2b28a210ca37a500d7e95572ce6126994d

commit 8a8b6c2b28a210ca37a500d7e95572ce6126994d
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon Jan 23 18:37:47 2017

ContentSecurityPolicy: Fix bug when CSPSource host-part = "*"

There were two problems. The first one was that when the host-part was
"*" then CSPSource::IsSchemeOnly() returned true, even if there was a
path or a port to enforce. For instance when source-expression =
'http://*:111' then 'http://a.com:222' was allowed.
The second problem was that in CSPSource::hostmatches(), the
host-part == '*' case was not handled.

This patch adds tests for these special cases.

BUG= 682673 

Review-Url: https://codereview.chromium.org/2646773002
Cr-Commit-Position: refs/heads/master@{#445417}

[modify] https://crrev.com/8a8b6c2b28a210ca37a500d7e95572ce6126994d/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp
[modify] https://crrev.com/8a8b6c2b28a210ca37a500d7e95572ce6126994d/third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp

Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 24 2017

Labels: Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, May 2 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Description: Show this description

Sign in to add a comment