New issue
Advanced search Search tips

Issue 682670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

HeadlessWebContentsSecurityTest.RunAsyncTest failing.

Project Member Reported by mkwst@chromium.org, Jan 19 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5466789f07c47118956eaca0a9baf4f35b02737b

commit 5466789f07c47118956eaca0a9baf4f35b02737b
Author: mkwst <mkwst@chromium.org>
Date: Thu Jan 19 13:38:22 2017

Revert of [headless] Fix screenshots with gpu enabled. (patchset #5 id:100001 of https://codereview.chromium.org/2631263003/ )

Reason for revert:
HeadlessWebContentsSecurityTest.RunAsyncTest is failing: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/steps/headless_browsertests/logs/HeadlessWebContentsSecurityTest.RunAsyncTest

Started in https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51027/. This is the only patch in the build that touches headless, so...

BUG= 682670 

Original issue's description:
> [headless] Fix screenshots with gpu enabled.
>
> Turns out this is due to two things:
> 1) We were overriding ShouldCreateCompositorFrameSink in the browser
>    compositor to always return false (which is unnecessary).
> 2) Contrary to what GpuBrowserCompositorOutputSurface and
>    SoftwareBrowserCompositorOutputSurface do, the
>    OffscreenBrowserCompositorOutputSurface wasn't letting the RWHI know
>    about swapped frames.
>
> This fixes both issues.
>
> BUG= 681614 
>
> Review-Url: https://codereview.chromium.org/2631263003
> Cr-Commit-Position: refs/heads/master@{#444694}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5077ffe4f7a3d8c053e8bd8b2070bc699ca937f

TBR=skyostil@chromium.org,jbauman@chromium.org,bsalomon@google.com,eseckler@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 681614 

Review-Url: https://codereview.chromium.org/2641073004
Cr-Commit-Position: refs/heads/master@{#444720}

[modify] https://crrev.com/5466789f07c47118956eaca0a9baf4f35b02737b/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/5466789f07c47118956eaca0a9baf4f35b02737b/content/browser/compositor/offscreen_browser_compositor_output_surface.cc
[modify] https://crrev.com/5466789f07c47118956eaca0a9baf4f35b02737b/content/browser/compositor/offscreen_browser_compositor_output_surface.h
[modify] https://crrev.com/5466789f07c47118956eaca0a9baf4f35b02737b/headless/BUILD.gn
[delete] https://crrev.com/cf2df2fe7c69089d5e6f23863eb41afb3cf7c5c2/headless/lib/DEPS
[modify] https://crrev.com/5466789f07c47118956eaca0a9baf4f35b02737b/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/5466789f07c47118956eaca0a9baf4f35b02737b/headless/test/headless_browser_test.h

Owner: eseckler@chromium.org
Status: Assigned (was: Untriaged)
fix is out here: https://codereview.chromium.org/2645683005
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76edc3b46251f2bd425cd5b7bc90922fddb657d7

commit 76edc3b46251f2bd425cd5b7bc90922fddb657d7
Author: eseckler <eseckler@chromium.org>
Date: Thu Jan 19 14:36:05 2017

Make HeadlessWebContentsSecurityTest disable observer before completion.

Otherwise, a future call to OnSecurityStateChanged may cause a
segmentation fault.

BUG= 682670 

Review-Url: https://codereview.chromium.org/2645683005
Cr-Commit-Position: refs/heads/master@{#444726}

[modify] https://crrev.com/76edc3b46251f2bd425cd5b7bc90922fddb657d7/headless/lib/headless_web_contents_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment