Issue metadata
Sign in to add a comment
|
Regression: Learn more link is misplaced for flash blocked bubble for Secondary UI flag
Reported by
dmascare...@etouch.net,
Jan 19 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version:57.0.2986.0 (Official Build) canary (64-bit) Revision 12c8d70173fc1a04fa588b75be71ab5e80655c60-refs/heads/master@{#444600} OS: Mac Retina (10.12.0) Pre-condition: 1. Click on radio button of Block site from running Flash option from chrome://settings/content 2. Enable Material Design in the rest of the browser's native UI flag from chrome://flags What steps will reproduce the problem? 1. Launch chrome and navigate to http://www.bbc.com/news/10462520 2. Click on Blocked plugins icon present in omnibox near star icon such that bubble open and observe link. Actual: Learn more link is misplaced for flash blocked bubble. Expected: Learn more link should be proper location for flash blocked bubble. This is regression issue, broke in ‘M 57’ and below is manual bisect: Good build:57.0.2977.0 Bad build:57.0.2978.0 Note: Issue is not seen on Windows and Linux Os.
,
Jan 20 2017
[Mac Triage] Waiting for bisect.
,
Jan 20 2017
Bisect Info: =========== Good build : 57.0.2977.0, Revision Range -442447 Bad build : 57.0.2978.0, Revision Range -442756 After executing the bisect(old) script , i got the following CL's between good and bad build versions =========================================== https://chromium.googlesource.com/chromium/src/+log/24ccd0688d195440d8c37f0f256d9a379a25db25..6f65367144842fdae99355bcd3c0b0aa85067122 The suspecting Fixed Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/acc4214c4dece4e70fb53355d557bd45f35965d6 From the above CL suspecting the below change --------------------------- Review-Url: https://codereview.chromium.org/2622773004 thomasanderson@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner.
,
Jan 20 2017
I think this may be it instead - https://codereview.chromium.org/2571613002.
,
Jan 25 2017
What are the Material Design rules for this case? Right now the bubble content title and the "learn more" link are separate controls within separate cells of the grid layout.
,
Jan 25 2017
bettes@ - what should the layout be here (see before/after screenshot at the top of the bug report)?
,
Apr 12 2017
,
May 26 2017
,
May 28 2017
Issue 652030 has mocks for this dialog. It has the 'Learn More' link moved to the extra view slot, and manage plugins moved to a button (OK button?), with Cancel ("Done") set as the default button. We are, however, missing mocks for some of the other "content settings" dialogs - Issue 700196
,
May 29 2017
,
May 30 2017
,
Jul 17 2017
Dialog width-snapping has effectively "un-regressed" this. The regression is just a change to layout, so I claim it's not a regression, and we just deal with it in Issue 652030 when this is reimplemented according to mocks |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jan 19 2017Status: Untriaged (was: Unconfirmed)