Chromad: Account for delayed password propagation after machine account creation |
||||||||||||
Issue descriptionLarge AD deployments can be slow to propagate machine account creation which causes enrollment to fail. To account for that, kinit is retried if it happens directly after enrollment.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a378ffbc617c80bdd89519c7d696ea9fe55da28 commit 3a378ffbc617c80bdd89519c7d696ea9fe55da28 Author: tnagel <tnagel@chromium.org> Date: Thu Jan 19 16:13:24 2017 Chromad: Increase D-Bus timeout for device policy fetch The first device policy fetch after joining Active Directory can be very slow because machine credentials need to propagate through the AD deployment. BUG= 682641 Review-Url: https://codereview.chromium.org/2644893002 Cr-Commit-Position: refs/heads/master@{#444754} [modify] https://crrev.com/3a378ffbc617c80bdd89519c7d696ea9fe55da28/chromeos/dbus/auth_policy_client.cc
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7c95a9d2e10f5daad5ed8092fda353248fa65872 commit 7c95a9d2e10f5daad5ed8092fda353248fa65872 Author: Thiemo Nagel <tnagel@chromium.org> Date: Thu Jan 19 16:25:29 2017 authpolicy: Add retries for kinit after domain join The first device policy fetch after joining Active Directory can be very slow because machine credentials need to propagate through the AD deployment. In that situation, retry kinit up to 60 times. BUG= chromium:682641 TEST=manual Change-Id: I11b4687a999d1d810744751aafb1057ef46dc6a1 Reviewed-on: https://chromium-review.googlesource.com/430754 Commit-Ready: Thiemo Nagel <tnagel@chromium.org> Tested-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/7c95a9d2e10f5daad5ed8092fda353248fa65872/authpolicy/samba_interface.h [modify] https://crrev.com/7c95a9d2e10f5daad5ed8092fda353248fa65872/authpolicy/samba_interface.cc
,
Jan 23 2017
,
Jan 23 2017
Verified on 9208.0.0 canary. Requesting to merge the CL from comment #3 (7c95a9d2e10f5d...) to release-R57-9202.B.
,
Jan 23 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2017
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c5eccf22a61244ac473553724698459c25f06b3e commit c5eccf22a61244ac473553724698459c25f06b3e Author: Thiemo Nagel <tnagel@chromium.org> Date: Thu Jan 19 16:25:29 2017 authpolicy: Add retries for kinit after domain join The first device policy fetch after joining Active Directory can be very slow because machine credentials need to propagate through the AD deployment. In that situation, retry kinit up to 60 times. BUG= chromium:682641 TEST=manual Change-Id: I11b4687a999d1d810744751aafb1057ef46dc6a1 Previous-Reviewed-on: https://chromium-review.googlesource.com/430754 (cherry picked from commit 2e96ab4e56b7907e3dd5c4b011da553a96beef54) Reviewed-on: https://chromium-review.googlesource.com/430695 Tested-by: Thiemo Nagel <tnagel@chromium.org> Trybot-Ready: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/c5eccf22a61244ac473553724698459c25f06b3e/authpolicy/samba_interface.h [modify] https://crrev.com/c5eccf22a61244ac473553724698459c25f06b3e/authpolicy/samba_interface.cc
,
Jan 24 2017
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5c665a278204a485b426eaac52e20938d2be5739 commit 5c665a278204a485b426eaac52e20938d2be5739 Author: Thiemo Nagel <tnagel@chromium.org> Date: Tue Jan 24 16:41:09 2017 authpolicy: Fix error code for kinit retries Set ERROR_NONE in case of initial fail but successful retry. BUG= chromium:682641 TEST=manual Change-Id: If2a56c9425fa3ae4949a53012a28c10f17c762fe Reviewed-on: https://chromium-review.googlesource.com/431035 Commit-Ready: Thiemo Nagel <tnagel@chromium.org> Tested-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/5c665a278204a485b426eaac52e20938d2be5739/authpolicy/samba_interface.cc
,
Jan 26 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 26 2017
Removing Merge-Approved-57 as directed by sheriffbot.
,
Jan 27 2017
Verified the full enrollment flow end-to-end on 9225.0.0 canary. Requesting to merge the CL from comment #10 (5c665a278204a48...) to release-R57-9202.B.
,
Jan 27 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b8b56d016563296b293f4adbbdb81899de484a31 commit b8b56d016563296b293f4adbbdb81899de484a31 Author: Thiemo Nagel <tnagel@chromium.org> Date: Tue Jan 24 16:41:09 2017 authpolicy: Fix error code for kinit retries Set ERROR_NONE in case of initial fail but successful retry. BUG= chromium:682641 TEST=manual Change-Id: If2a56c9425fa3ae4949a53012a28c10f17c762fe Reviewed-on: https://chromium-review.googlesource.com/431035 Commit-Ready: Thiemo Nagel <tnagel@chromium.org> Tested-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> (cherry picked from commit 5c665a278204a485b426eaac52e20938d2be5739) Reviewed-on: https://chromium-review.googlesource.com/433739 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/b8b56d016563296b293f4adbbdb81899de484a31/authpolicy/samba_interface.cc
,
Jan 30 2017
Merge is done. Removing Merge-Approved-57 and closing out.
,
Mar 24 2017
as per #15 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by tnagel@chromium.org
, Jan 19 2017Status: Started (was: Available)