New issue
Advanced search Search tips

Issue 682640 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.9%-135.4% regression in webrtc_perf_tests at 16127:16128

Project Member Reported by nisse@chromium.org, Jan 19 2017

Issue description

See the link to graphs below.
 

Comment 2 by nisse@chromium.org, Jan 19 2017

Hello,

these perf graph shows lots of changes, which could perhaps be explained as a result of the improved bandwidth estimate from your cl https://codereview.webrtc.org/2613543003

Can you have a look and say if these changes are expected and reasonable?

Comment 3 by holmer@chromium.org, Jan 19 2017

Who should this be assigned to?

Comment 4 by nisse@chromium.org, Jan 19 2017

Owner: sergeyu@chromium.org
Status: Assigned (was: Untriaged)
It was intended for sergeyu. Reassigning.
Status: WontFix (was: Assigned)
I don't think there is anything actionable.
On Mac foreman_cif_delay_50_0_plr_5_ulpfec gets higher BW estimate as result more time is spent in the encoder.
Same in screenshare_slides_vp9_2sl: the sender gets a bit higher BW esimates that changes the number we get in that test.
TransportSequenceNumberSimulcastRedRtx seems rather noisy and is affected even by debug logging. 10packets is the same value it gets on Linux before my change

Comment 6 by nisse@chromium.org, Jan 23 2017

Cc: holmer@chromium.org
Thanks for looking into this. 

Stefan, do you agree no further action is needed regarding the ramp-up graphs? Packets sent increased from 6 to 10, and I guess most of the other graphs (byte counters and delays) follow from that.

Comment 7 by holmer@chromium.org, Jan 23 2017

yeah, seems ok.
For the record, the culprit CL was reverted in https://codereview.webrtc.org/2626473004/ (15979), and relanded in 16127.

Sign in to add a comment