Both Yes and No options are seen in chrome://ntp-tiles-internals/ of incognito and guest mode |
|||
Issue descriptionChrome Version: 57.0.2986.0 dev OS: Windows,Ubuntu 14.04 What steps will reproduce the problem? (1)Open chrome://ntp-tiles-internals/ in Incognito/Guest mode and observe enabled options under topsites,suggestions,service Expected: Either of the one [Yes or No] should be seen. Actual: Instead both yes and no are seen. This is a Non-regression issue seen from 57.0.2986.0 dev. Till 57.0.2985.0 chrome crashes on naviagting to above url in incognito/guest mode.
,
Jan 19 2017
Able to reproduce the issue on Mac 10.12.1 using chrome version 57.0.2986.0
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6336797781587abf6c3fa648d034315714d1134 commit d6336797781587abf6c3fa648d034315714d1134 Author: sfiera <sfiera@chromium.org> Date: Mon Feb 27 15:44:08 2017 chrome://ntp-tiles-internals: hide when incognito Previously I just disabled the callbacks. In addition to that, send back an empty configuration and site list, to make the page properly display that everything is disabled and there are no sites in incognito. Without this change, the "View JSON" button appears for popular sites, but causes a crash because there's no PopularSites object. BUG= 682622 , 696471 ,681774 Review-Url: https://codereview.chromium.org/2721603002 Cr-Commit-Position: refs/heads/master@{#453220} [modify] https://crrev.com/d6336797781587abf6c3fa648d034315714d1134/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc [modify] https://crrev.com/d6336797781587abf6c3fa648d034315714d1134/components/ntp_tiles/webui/resources/ntp_tiles_internals.js
,
Feb 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sc00335...@techmahindra.com
, Jan 19 2017135 KB
135 KB View Download