New issue
Advanced search Search tips

Issue 682619 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 681625



Sign in to add a comment

Fix data size issues in authpolicy

Project Member Reported by tnagel@chromium.org, Jan 19 2017

Issue description

Anything that's large (large amount of GPOs, large GPO contents) breaks the piping in authpolicy.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/54b2da92851a678dde945176d619c5659c7a8e0e

commit 54b2da92851a678dde945176d619c5659c7a8e0e
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Jan 19 22:50:19 2017

authpolicy: Fix ProcessExecutor getting stuck with large data

If a process outputs more data than a pipe can hold, ProcessExecutor
gets stuck. This CL fixes this by performing IO before waiting for
the process to finish.

BUG= chromium:682619 
TEST=Compiles, unit tests work, verified that this fixes the bug

Change-Id: Id5e7dde132c3899454cff2e976260d02e5c4383a
Reviewed-on: https://chromium-review.googlesource.com/430737
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/54b2da92851a678dde945176d619c5659c7a8e0e/authpolicy/pipe_helper.h
[modify] https://crrev.com/54b2da92851a678dde945176d619c5659c7a8e0e/authpolicy/process_executor.cc
[modify] https://crrev.com/54b2da92851a678dde945176d619c5659c7a8e0e/authpolicy/process_executor_unittest.cc
[modify] https://crrev.com/54b2da92851a678dde945176d619c5659c7a8e0e/authpolicy/pipe_helper.cc
[modify] https://crrev.com/54b2da92851a678dde945176d619c5659c7a8e0e/authpolicy/samba_interface.cc

Comment 2 by tnagel@chromium.org, Jan 24 2017

Status: Fixed (was: Started)

Comment 3 by tnagel@chromium.org, Jan 24 2017

Cc: tnagel@chromium.org
Labels: Merge-Request-57
Tested on canary 58.0.2990.0 / 9215.0.0 (peppy).

Requesting to merge the CL from comment #1 (54b2da92851a67) to release-R57-9202.B.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 25 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 27 2017

Labels: merge-merged-release-R57-9202.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b1470613a56ba1e1aef15f1e5008f7a97f83af5a

commit b1470613a56ba1e1aef15f1e5008f7a97f83af5a
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Jan 19 22:50:19 2017

authpolicy: Fix ProcessExecutor getting stuck with large data

If a process outputs more data than a pipe can hold, ProcessExecutor
gets stuck. This CL fixes this by performing IO before waiting for
the process to finish.

BUG= chromium:682619 
TEST=Compiles, unit tests work, verified that this fixes the bug

Change-Id: Id5e7dde132c3899454cff2e976260d02e5c4383a
Reviewed-on: https://chromium-review.googlesource.com/430737
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
(cherry picked from commit 54b2da92851a678dde945176d619c5659c7a8e0e)
Reviewed-on: https://chromium-review.googlesource.com/433885
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/b1470613a56ba1e1aef15f1e5008f7a97f83af5a/authpolicy/pipe_helper.h
[modify] https://crrev.com/b1470613a56ba1e1aef15f1e5008f7a97f83af5a/authpolicy/process_executor.cc
[modify] https://crrev.com/b1470613a56ba1e1aef15f1e5008f7a97f83af5a/authpolicy/process_executor_unittest.cc
[modify] https://crrev.com/b1470613a56ba1e1aef15f1e5008f7a97f83af5a/authpolicy/pipe_helper.cc
[modify] https://crrev.com/b1470613a56ba1e1aef15f1e5008f7a97f83af5a/authpolicy/samba_interface.cc

Comment 6 by tnagel@chromium.org, Jan 30 2017

Labels: -Merge-Approved-57
Merge is done.  Removing Merge-Approved-57.
Status: Verified (was: Fixed)
as per #5

Sign in to add a comment