New issue
Advanced search Search tips

Issue 682613 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 583348



Sign in to add a comment

Enable H.264 assembly for OpenH264 encoding on Mac

Project Member Reported by hta@chromium.org, Jan 19 2017

Issue description

The OpenH264 encoder has assembly available for X64, and this was enabled for Windows and Linux in https://codereview.chromium.org/2585733002/

Enabling it on Mac did not work due to linker issues (too many visible symbols); fixing those seems to require patching the sources, upgrading yasm, or both.

The cost/benefit of fixing this has been questioned; most Macs use hardware H.264 encoders most of the time.

 

Comment 1 by hta@chromium.org, Mar 22 2017

Blocking: -600399

Comment 2 by hta@chromium.org, Mar 22 2017

Blockedon: 583348
@hta @hbos @sprang I am able to turn on assembler use in OpenH264 for OSX in the Chromium M60 branch and use the software encoder without any apparent linker errors or issues during execution. Is there a specific test that fails I can look into to get this enabled? Was this fixed by a recent roll of a newer OpenH264 version? Please let me know. Thanks
Components: Internals>Media>Codecs
Status: WontFix (was: Untriaged)
this bug has been stale for > 10 month. I'll close it now. please feel free to reactivate and assign appropriately if needed.

Sign in to add a comment