New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682611 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4870.4%-5772.2% regression in webrtc_perf_tests at 16135:16136

Project Member Reported by nisse@chromium.org, Jan 19 2017

Issue description

See the link to graphs below.
 

Comment 2 by nisse@chromium.org, Jan 19 2017

Owner: holmer@chromium.org
Status: Assigned (was: Untriaged)
This looks like a regression in ramp-up tests on Android. I could need some help with triaging. Change appears around commit #16136, neighboring changes include

Move congestion controller processing to the pacer thread.

Add experimental simulcast screen content mode.

Fix race in EndToEndTest.ReceivesFlexfecAndSendsCorrespondingRtcp.

Improve computational performance of BWE by switching list to deque.

Refactor OveruseFrameDetector to use timing in us units

(all by our team or close neighbors). Nothing obviously related to rampup or android in particular.

Comment 4 by holmer@chromium.org, Jan 19 2017

Cc: sergeyu@chromium.org glaznev@chromium.org holmer@chromium.org
Owner: nisse@chromium.org
The reason I suspect one of those is:

- the first changes bitrate probing, and the issue is that we send more while ramping up than before.

- the second one changes the Android encoder, shouldn't affect this since we're using a fake encoder, so please ignore this one!

- the third one changes threads related to probing. Could perhaps be that what we're now doing on the pacer thread affects pacing negatively so that probing breaks on this device.

I'd suggest rolling back 1 and/or 3 to start with.

Comment 5 by nisse@chromium.org, Jan 19 2017

cl 1 caused lots of other changes (which may be improvements rather than regressions?). See https://bugs.chromium.org/p/chromium/issues/detail?id=682640

I suspect these android changes are something different. I'll start with reverting my pacer thread cl.

Comment 6 by nisse@chromium.org, Jan 20 2017

Cc: philipel@chromium.org
Graphs are now back to normal. It looks like they returned to old values with the revert of new jitterbuffer, https://codereview.webrtc.org/2638423003, commit #16159. My revert of the threading change landed a few hours later, as #16163, so it's hard to draw any solid conclusion.

Comment 7 by holmer@chromium.org, Jan 20 2017

Tricky. Maybe we should reland your change and see if it starts reproducing again or not.
Labels: -Restrict-View-Google
Removing R-V-G label (was set upon bug filing because the bot was incorrectly configured as internal)

Sign in to add a comment