Issue metadata
Sign in to add a comment
|
1.7% regression in webrtc_perf_tests at 16059:16059 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 19 2017
Hi, this is a small but reasonable clear performance change, which seem to be related with your cl https://codereview.webrtc.org/2589713003. Can you have a look? It's unclear to me what the test means, I couldn't find it in the list referenced from the perf sheriff document. Other nearby cls are https://codereview.webrtc.org/2623513002 and https://codereview.webrtc.org/2625893004
,
Jan 20 2017
I don't think its related to https://codereview.webrtc.org/2589713003 since the NetEQ test shouldn't have FlexFEC enabled. Same goes for https://codereview.webrtc.org/2623513002. https://codereview.webrtc.org/2625893004 also looks pretty harmless to me, since I think the target bitrate feedback message is only used in multiway calls. sprang@: Is this correct? hlundin@ knows more about this test I believe, would you mind taking a look?
,
Jan 23 2017
It is correct, the target bitrate actually isn't used anywhere yet, but will be used in muc scenarios in the future. I have a hard time seeing that disabling the sending of the occasional unnecessary rtcp overhead would negatively impact performance.
,
Jan 24 2017
Seems to have recovered in the range 16208-16212 (https://chromium.googlesource.com/external/webrtc/+log/011240333ee22408cdd96d1e4f41dee07af15034..9c3d4c4d881be595dd8e68e2130f23d9f4fab057). Closing this. We've got bigger fish to fry. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by nisse@chromium.org
, Jan 19 2017