New issue
Advanced search Search tips

Issue 682606 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

HTTP Cache Age calculation mechanism changed with RFC 7234

Reported by billy.ja...@samsung.com, Jan 19 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Example URL:

Steps to reproduce the problem:
Current implementation is aligned with RFC 2616 which is obsolete now[1].
This bug is to track/discuss on the new spec RFC 7234 section[2]
[1]http://httpwg.org/specs/
[2]http://httpwg.org/specs/rfc7234.html#rfc.section.4.2.3

What is the expected behavior?

What went wrong?
HTTP cache age calculation correction.

Did this work before? N/A 

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 24.0 r0
 
Uploaded a patch addressing the same.
You can find it here https://codereview.chromium.org/2644063003. PTAL

Comment 2 by mmenke@chromium.org, Jan 19 2017

Owner: jkarlin@chromium.org
Status: Assigned (was: Unconfirmed)
Marking this as assign to jkarlin, who's doing the review for billy.jayan (Since can't assign issues to people who aren't project members).
sgtm
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c767da1904a215d821f211fc01cd5a1da0096858

commit c767da1904a215d821f211fc01cd5a1da0096858
Author: billy.jayan <billy.jayan@samsung.com>
Date: Wed Jan 25 06:02:37 2017

HTTP Cache Age calculation mechanism changed with RFC 7234

Current cached resource age calculation implementation in chromium references and uses RFC 2616
which has been obsoleted by RFC 7234. The new spec has minor modification with
respect to age calculation ([1] & [2])

Old spec: https://tools.ietf.org/html/rfc2616#section-13.2.3
New spec: http://httpwg.org/specs/rfc7234.html#rfc.section.4.2.3

BUG= 682606 

Review-Url: https://codereview.chromium.org/2644063003
Cr-Commit-Position: refs/heads/master@{#445964}

[modify] https://crrev.com/c767da1904a215d821f211fc01cd5a1da0096858/net/http/http_response_headers.cc
[modify] https://crrev.com/c767da1904a215d821f211fc01cd5a1da0096858/net/http/http_response_headers_unittest.cc

Comment 5 by mmenke@chromium.org, Jan 31 2017

jkarlin:  I think this is fixed now?
Status: Fixed (was: Assigned)
Thanks billy.jayan!

Sign in to add a comment