Regression: Incognito window does not properly reset after applying theme.
Reported by
rk...@etouch.net,
Jan 19 2017
|
||||||
Issue descriptionChrome Version:57.0.2986.0 (Official Build) 12c8d70173fc1a04fa588b75be71ab5e80655c60-refs/heads/master@{#444600} 32/64-bit. OS:Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1) Pre-Condition: Apply theme to the browser. What steps will reproduce the problem? (1) Launch chrome, open two incognito window. (2) Then Reset to default theme from chrome://settings. (3) Observe one of the incognito window. Actual: Incognito window does not reset to default properly. Expected: Incognito window should reset to default properly. This is a regression issue, broken in 'M-55', will soon update the other info: Good Build: 55.0.2879.0 Bad Build: 55.0.2880.0
,
Jan 19 2017
I don't think https://codereview.chromium.org/2386823002 would have caused this. Can we get another bisect?
,
Jan 20 2017
Using the per-revision bisect providing the bisect results, Good build: 55.0.2879.0 (Revision: 422347) Bad build: 55.0.2880.0 (Revision: 422654) After executing the bisect(old) script , i got the following CL's between good and bad build versions =========================================== https://chromium.googlesource.com/chromium/src/+log/99c2073218960208c0f54de95b9c31ff9521ba46..a525387e44b256f162626c25fa14dd199d9c4094 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/a525387e44b256f162626c25fa14dd199d9c4094 From the above CL suspecting the below change --------------------------- Review-Url: https://codereview.chromium.org/2391763003 michaelpg@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner.
,
Jan 20 2017
Sorry for the typo mistake, for this issue, per-revision bisect script was executed.
,
Feb 1 2017
Themes don't even have permissions (I checked that specific CRX). Unless there's something weird happening in the manifest_features generator (devlin?) I don't think my change seems likely either. From the white full-screen flicker when the reset button is hit in the "Actual" video, and the weirdness of the Incognito window afterwards, I wonder if this is some kind of graphics glitch. Getting two different bisect results is suspicious too.
,
Feb 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2018
Can't reproduce this anymore. I suspect that it might have been fixed with the changes in the code around background colors that treib@ has been working on. Please reopen if this still can be reproduced under some circumstances. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rbasuvula@chromium.org
, Jan 19 2017Labels: hasbisect-per-revision
Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)