New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682604 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Incognito window does not properly reset after applying theme.

Reported by rk...@etouch.net, Jan 19 2017

Issue description

Chrome Version:57.0.2986.0 (Official Build) 12c8d70173fc1a04fa588b75be71ab5e80655c60-refs/heads/master@{#444600} 32/64-bit. 
OS:Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

Pre-Condition: Apply theme to the browser.

What steps will reproduce the problem?
(1) Launch chrome, open two incognito window.
(2) Then Reset to default theme from chrome://settings.
(3) Observe one of the incognito window.

Actual: Incognito window does not reset to default properly.

Expected: Incognito window should reset to default properly.

This is a regression issue, broken in 'M-55', will soon update the other info:

Good Build: 55.0.2879.0
Bad Build: 55.0.2880.0
 
Actual_Theme.mp4
1.1 MB View Download
Expected_Theme.mp4
1.5 MB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2879.0 (Revision: 422347)
Bad build: 55.0.2880.0 (Revision: 422654)

You are probably looking for a change made after 422588 (known good), but no later than 422589 (first known bad).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/745fe06919e14e926d3464f64bc2f0d91b00b326..fd7bb627894ab5fc1415c90f579dba779fddc70f


From the CL above, assigning the issue to the concern owner

@rdevlin.cronin: 
------------------
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2386823002

Note: Able to reproduce the issue on Mac 10.12.2,Ubuntu 14.04 & Win7.
Cc: rdevlin....@chromium.org
Labels: -hasbisect-per-revision Needs-Bisect
Owner: ----
Status: Untriaged (was: Assigned)
I don't think https://codereview.chromium.org/2386823002 would have caused this.  Can we get another bisect?

Cc: kkaluri@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: michae...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2879.0 (Revision: 422347)
Bad build: 55.0.2880.0 (Revision: 422654)


After executing the bisect(old) script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/99c2073218960208c0f54de95b9c31ff9521ba46..a525387e44b256f162626c25fa14dd199d9c4094

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a525387e44b256f162626c25fa14dd199d9c4094

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2391763003

michaelpg@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.


Sorry for the typo mistake, for this issue, per-revision bisect script was executed. 
Cc: michae...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Themes don't even have permissions (I checked that specific CRX). Unless there's something weird happening in the manifest_features generator (devlin?) I don't think my change seems likely either.

From the white full-screen flicker when the reset button is hit in the "Actual" video, and the weirdness of the Incognito window afterwards, I wonder if this is some kind of graphics glitch. Getting two different bisect results is suspicious too.
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: treib@chromium.org
Status: Fixed (was: Untriaged)
Can't reproduce this anymore. I suspect that it might have been fixed with the changes in the code around background colors that treib@ has been working on.

Please reopen if this still can be reproduced under some circumstances.

Sign in to add a comment