New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682593 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Wrong orientation of a photo in quick view (EXIF Orientation)

Project Member Reported by yamaguchi@chromium.org, Jan 19 2017

Issue description

Chrome Version: 56.0.2924.53
Chrome OS Version: 9000.50.0
Chrome OS Platform: Chromebook Pixel
Network info: not relevant

Also confirmed with 57.0.2970.0 / 9148.0.0.


Steps To Reproduce:
(1) Prepare an image file with EXIF orientation != 1.
(2) Open the folder in the Files app.
(3) Choose the image file.
(4) Hit space key to see the image in quick view.

(Optionally, compare it with the one in the thumbnail or in Gallery app.)

Expected Result:
Quick view shows the image in the right orientation.

Actual Result:
The image appears wrongly rotated, without EXIF orientation applied.
For example, upside left.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
This will affect all image files that satisfies the condition. Typically, such files can be generated by taking picture in portrait orientation using certain models of digital still cameras.
As a workaround, Gallery app can be used to view an image.

 
Description: Show this description

Comment 2 by oka@chromium.org, Jan 19 2017

Quick view controller should apply transoform in metadata.

Comment 3 by oka@chromium.org, Jan 19 2017

Status: Started (was: Untriaged)

Comment 4 by oka@chromium.org, Jan 23 2017

Status: Assigned (was: Started)

Comment 5 by oka@chromium.org, Jan 23 2017

Labels: Hotlist-GoodFirstBug
There are 2 cases.
1. If a file is in Google Drive, data from Google Drive is used.
 Drive gives wrong orientation for some EXIF orientation types (2, 4, 5 and 7). The client is WAI for this case.
2. If a file is local (Downloads, USB disk), it's loaded via createObjectURL. It seems to strip the EXIF information. I haven't found the exact document about this behavior, but I found some articles reporting relevant problems.
http://stackoverflow.com/questions/19463126/how-to-draw-photo-with-correct-orientation-in-canvas-after-capture-photo-by-usin

I think we can load thumbnail by ThumbnailLoader / ImageLoader if it doesn't affect the performance.
FYI
https://drafts.csswg.org/css-images-3/#the-image-orientation
Browsers should show an image in img element without applying EXIF orientation in the file, unless "image-orientation: from-image" is specified. The attribute is not implemented in Chrome yet.
https://bugs.chromium.org/p/chromium/issues/detail?id=158753

Comment 8 by fukino@chromium.org, Jul 19 2017

Cc: yamaguchi@chromium.org oka@chromium.org fukino@chromium.org
Owner: klemenko@google.com
Owner: ----
Status: Available (was: Assigned)
Cc: noel@chromium.org

Comment 12 by noel@chromium.org, Feb 16 2018

Status: ExternalDependency (was: Available)

Comment 13 by noel@chromium.org, Feb 16 2018

Related  issue 680414 
Labels: CrOS-FilesApp-QuickView
Labels: -CrOS-FilesApp-QuickView CrOSFilesFeature-QuickView

Sign in to add a comment