New issue
Advanced search Search tips

Issue 682590 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

[Missing Tests]: [Mac] Prevent omnibox text bg from drawing over decoration, focus ring.

Project Member Reported by kavvaru@chromium.org, Jan 19 2017

Issue description

shrike@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit:  https://codereview.chromium.org/2562863002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=669870

Thanks,
 
 
Cc: shrike@chromium.org
 Issue 683059  has been merged into this issue.
Labels: -M-56 M-58
Labels: -Pri-1 Pri-2
Components: -Test>Missing Tests>Missing

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by shrike@chromium.org, Jan 25 2018

Cc: -shrike@chromium.org
Owner: ----
Status: WontFix (was: Assigned)
Without thinking much about this bug I assumed it would be a matter of ensuring proper, non-overlapping rects for the background text, decorations, etc. However looking at the change the issue was the decorations, etc. being drawn before the background. The fix was to change their relative drawing order. I'm not sure a test to check this is writable. Marking WontFix but please reopen if you have an approach that makes sense and you are interested in implementing it.

Sign in to add a comment