bluetooth: Cancelling StopNotifySession commands does not remove them from the queue of commands |
||||
Issue description
The StopNotifySessionCommand's cancel_callback is initialized to 'callback' rather than to CancelStopNotifySession[1]. This means that when a StopNotifySession command is canceled it is not taken out of the queue.
[1] should be changed to:
NotifySessionCommand* command = new NotifySessionCommand(
base::Bind(&BluetoothRemoteGattCharacteristic::ExecuteStopNotifySession,
GetWeakPtr(), session, callback),
base::Bind(&BluetoothRemoteGattCharacteristic::CancelStopNotifySession,
GetWeakPtr(), callback));
[1] https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_remote_gatt_characteristic.cc?q=executestopnotifysession&sq=package:chromium&dr=C&l=235
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b6e266b8955aa81a7dcc4ea4d3796e5be9f7cce commit 0b6e266b8955aa81a7dcc4ea4d3796e5be9f7cce Author: jlebel <jlebel@chromium.org> Date: Thu Jan 19 18:20:47 2017 Bluetooth: macOS: Cancelling StopNotifySession commands. When cancelling StopNotifiySession command should remove them from the queue of commands. BUG= 682583 Review-Url: https://codereview.chromium.org/2644463005 Cr-Commit-Position: refs/heads/master@{#444791} [modify] https://crrev.com/0b6e266b8955aa81a7dcc4ea4d3796e5be9f7cce/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
,
Jan 19 2017
Thanks for the fix. Leaving opened as tests are missing.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af286b82f997fada45bb41a90e6ffb6bf9d2a242 commit af286b82f997fada45bb41a90e6ffb6bf9d2a242 Author: ortuno <ortuno@chromium.org> Date: Mon Jan 23 01:26:55 2017 bluetooth: Test cancelling a Stop notify session request Adds tests for http://crrev.com/2644463005 BUG= 682583 Review-Url: https://codereview.chromium.org/2646443010 Cr-Commit-Position: refs/heads/master@{#445310} [modify] https://crrev.com/af286b82f997fada45bb41a90e6ffb6bf9d2a242/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
,
Mar 4 2017
,
Mar 4 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jlebel@chromium.org
, Jan 19 2017