Issue metadata
Sign in to add a comment
|
Different icons for Cast devices in ChromeOS system tray |
|||||||||||||||||||||||||
Issue descriptionChrome Version: 56.0.2924.67 (Official Build) beta (64-bit) OS: 9000.66.0 (Official Build) beta-channel samus What steps will reproduce the problem? (1) Have Cast and Cast for Audio devices available on your WiFi (2) Open the ChromeOS system tray and select "Cast Devices Available" What is the expected result? Icons for Cast media sinks match those shown in the Media Router dialog (including different icons for Cast and Cast for Audio) per the first screenshot What happens instead? Some TV-ish icon is used instead for all media sinks per the second screenshot
,
Jan 19 2017
Sebastien, do you think any icons need changing here?
,
Jan 19 2017
Yes. Thanks for bringing that up. I have exported new assets for cast-device. Let's swap them.
,
Jan 19 2017
,
Feb 7 2017
Assigning to Jacob since he's owning a rework of cast detailed view in m-58.
,
Feb 14 2017
,
Feb 14 2017
Oops, wrong bug.
,
Mar 15 2017
,
Apr 19 2017
Ping Jacob.
,
Apr 19 2017
Waiting on a router so I can test locally again. This should land in M-60.
,
Apr 19 2017
,
May 31 2017
Quick ping, did this land for M60?
,
May 31 2017
Not yet, sorry.
,
Jun 12 2017
,
Aug 14 2017
,
Aug 14 2017
,
Aug 18 2017
I won't be able to take this, I'm going to unassign unless we have a better owner. Over the next two months I have higher launch priorities, privacy reviews, and a geotransfer (along with a lot of OOO days) so for M62 & M63 I can't take on new work.
,
Aug 18 2017
,
Aug 18 2017
+abodenha@ to find an owner
,
Aug 18 2017
,
Aug 28 2017
,
Sep 11 2017
,
Sep 11 2017
,
Nov 2 2017
,
Nov 16 2017
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50d262e208e7efa97a93d8ee28311945d04f6089 commit 50d262e208e7efa97a93d8ee28311945d04f6089 Author: Sammie Quon <sammiequon@google.com> Date: Mon Nov 27 22:29:06 2017 tray: Cast tray now shows different icon for different types of devices. The icons now match the ones show on the chrome media router interface. They used to just show a generic TV for all types. Some of the icons change depending on if the build is chrome branded, this is also to match the media router interface. Test: manual Bug: 682575 Change-Id: Ib410e42afbe78e1c4c72ab3794d44d26fa69cf13 Reviewed-on: https://chromium-review.googlesource.com/777462 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519426} [modify] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/public/interfaces/cast_config.mojom [modify] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_audio.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_audio.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_audio_group.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_audio_group.icon [modify] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_device.1x.icon [modify] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_device.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_education.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_education.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_generic.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_generic.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_hangout.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_hangout.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_meeting.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_meeting.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_message.1x.icon [add] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/resources/vector_icons/system_menu_cast_message.icon [modify] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/ash/system/cast/tray_cast.cc [modify] https://crrev.com/50d262e208e7efa97a93d8ee28311945d04f6089/chrome/browser/ui/ash/cast_config_client_media_router.cc
,
Nov 30 2017
Can this be marked fixed? We can ask our QA to verify.
,
Nov 30 2017
,
Dec 4 2017
Looks good, icons are updated! Verified on 64.0.3280.5 |
||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Jan 19 2017